Pulse focus

[RuslanPatyk]

Guys, it would be nice if there were some options for focus. You have implemented it in the way it is described in the material guide, user highlights the element and focus covers it in the form of wave. But one thing is missed: The "hamburger" button (menu button) in Google's inbox application is highlighted in a bit different way: it is highlighted using focus but the focus is not in the form of wave. Look at the app and you will understand what I mean. It would be great if you, guys, implemented this in the library. One option of enum, for example, for the pulse that is used now, the other one for the pulse used in the Inbox app, and the third one is a combination of 1st and 2nd one that is used throughout android apps. Thank you.

[daniel-jonathan]

You mean the circle look for the buttons? Yeah, I think it would be cool to move things to an enum, and then be able to grow the effects for pulse. Nice suggestion. I'll leave this issue up, and will roll something out very soon.

[RuslanPatyk]

No, not the circle look for the button, but the way the pulse behaves on a circle menu button of Inbox application. That circle button is just an example. First type - the type that is used now, second one - the type used on a button that I have written above and 3-d one is a combination of 1st and 2nd type, when 2nd type pulse is covered with 1st one, but 1st one is not as translucent as 2n one in such a case.

Thank you so much.

:)

On Mar 31, 2016, at 6:00 PM, Daniel Dahan notifications@github.com wrote:

You mean the circle look for the buttons? Yeah, I think it would be cool to move things to an enum, and then be able to grow the effects for pulse. Nice suggestion. I'll leave this issue up, and will roll something out very soon.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/CosmicMind/Material/issues/274#issuecomment-203976832

[daniel-jonathan]

I will look into it :)

As for the opacity, you could set the pulseOpacity, so you know.

[RuslanPatyk]

Yes…

Thank you

On Mar 31, 2016, at 6:30 PM, Daniel Dahan notifications@github.com wrote:

I will look into it :)

As for the opacity, you could set the pulseOpacity, so you know.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/CosmicMind/Material/issues/274#issuecomment-203987388

[RuslanPatyk]

It would be nice to reduce pulse delay on tap, it will give more responsiveness

[daniel-jonathan]

Yeah, when I rework the pulse, I will see what can be done. Any suggestions?

[colinmorelli]

@danieldahan if you plan on re-working the pulse, I do have a suggestion: I'd love to see the pulse bounds be resized, rather than scaled. In cases where you can see the bounds of the pulse, the edges are very distorted because of the scaling.

Here's an example where you can see the edges of the pulse, compared to the parts that are clipped by the visualLayer. Much cleaner lines on the clip than at the edges.

[daniel-jonathan]

@colinmorelli nice. Yes that is primarily why I want it redone. To make it crisp. Excellent suggestion.

[daniel-jonathan]

@RuslanPatyk Hi, I rewrote the pulse animation, to match this spec, the surface reaction and Material response. I am going to add an enum handler to set the different states. I will close this for now, and once the release is out, please test. Sorry, if this is closed early in your opinion, this is mainly to coordinate with what I have in development pending release.

[daniel-jonathan]

@colinmorelli I definitely agree about the scaling and have made some changes. I will be adding a new type of scale, or correcting it based on the scaleFactor, which was not set. Thank you!