CosmicMind / Material

A UI/UX framework for creating beautiful applications.
http://cosmicmind.com
MIT License
11.98k stars 1.26k forks source link

NavigationItem Controls Out of View on Form Sheet #386

Closed zgosalvez closed 8 years ago

zgosalvez commented 8 years ago

On the iPad, if the view controller is presented modally as a form sheet, the left and right controls of navigationItem are out of view. However, for some reason, I can't find it in the view debugger.

daniel-jonathan commented 8 years ago

Nice catch. I will take a look at this in the morning. Thank you!

daniel-jonathan commented 8 years ago

Can you try the latest and tell me if this persists 1.41.2.

zgosalvez commented 8 years ago

This issue still persists in 1.41.2.

daniel-jonathan commented 8 years ago

Can you send me a sample project with this issue? to support@cosmicmind.io

zgosalvez commented 8 years ago

Sent.

mohpor commented 8 years ago

@zgosalvez , @danieldahan Can you loop me in? I'm not sure about the setup resulting to this issue. I could reproduce it in my own way, but I'm not sure if that addresses the same problem here.

mohpor commented 8 years ago

@zgosalvez Can you test your project against this pod to see if your issue is solved?

pod 'Material', :git => 'https://github.com/mohpor/Material.git', :branch => 'development'

thanks

P.S.: your sample project works with this patch.

zgosalvez commented 8 years ago

@mohpor Your fix works for my actual project. 😀 Awesome! Excited for the official patch release. Thanks, man.

mohpor commented 8 years ago

Glad it helped. There will be an appropriate fix for it ASAP.

daniel-jonathan commented 8 years ago

Thank you @mohpor :) And the fix will be out latest tomorrow morning.

daniel-jonathan commented 8 years ago

This is fixed in the latest release 1.41.3