Closed rstoneback closed 5 years ago
Addresses issue #16
Test failures are related to some configuration issues on Travis CI. The code itself is fine.
Review requested from @bharding512
Some of the features here have been supplanted by the next pull. Next pull needs a bit of documentation work but the underlying code changes are good to go.
No rush as I've already delivered results to ICON.
Closed per feedback and notes in pull #26
A user ran into a calculation failure when the number of steps allowed for field_line_trace was large enough that the integration terminated early, resulting in downstream calculation errors. Corrected this by filtering outputs after the minimum distance to the desired termination height is reached. Downside: the extra calls to the ECEF/Geodetic conversion slow things down. Conversion to Fortran is worth it.
While investigating this issue, a problem with step_until_intersect was found and corrected. The method now does a better job searching for the closest distance. More accurate and more robust to changes in parameters. A tolerance keyword, 'tol', was added.
Corrected a small pysat version bug.
To be completed: