search

Cosmo / TinyConsole

📱💬🚦 TinyConsole is a micro-console that can help you log and display information inside an iOS application, where having a connection to a development computer is not possible.
MIT License
1.96k stars 89 forks source link

add iOS 8 support #5

Closed wangguangfeng closed 7 years ago

wangguangfeng commented 7 years ago

add iOS version check where the Auto Layout Layout Anchor API is used.

wangguangfeng commented 7 years ago

This pull request is for iOS 8 support

Cosmo commented 7 years ago

@wangguangfeng, that was quick 🚀!

One thing before merging: I've tried your fork on the iOS 8 simulator, but the 2-finger-tap gesture does not work for me. Any ideas?

wangguangfeng commented 7 years ago

The two-fingers-tap gesture on the viewcontroller is blocked by the gesture on the textview. To fix the bug, i add the two-fingers-tap gesture on the textview.

Cosmo commented 7 years ago

Does the 3 finger tap still work? I can't really test or verify, because I don't own an iOS 8 device anymore. And the ~development~ deployment target needs to be changed to iOS 8 to make it work.

Thanks!

wangguangfeng commented 7 years ago

I have tested, 3-finger-tap works fine.

Cosmo commented 7 years ago

Ok, great! Do you want to change the deployment target to iOS 8 before I make the merge?

wangguangfeng commented 7 years ago

OK，but I will change the deployment target to iOS 8 tomorrow.

wangguangfeng commented 7 years ago

I have changed the deployment target to iOS 8.

Cosmo commented 7 years ago

👍 Awesome, Thanks!

This resolves #2