search

CosmoStat / autometacal

Metacalibration and shape measurement by automatic differentiation
MIT License
4 stars 1 forks source link

Dataset #16

Closed andrevitorelli closed 3 years ago

andrevitorelli commented 3 years ago

The gal_gen dataset now works as a simple toy model.

EiffL commented 3 years ago

This is great @andrevitorelli.

So thinking of the next steps, as described here: https://github.com/CosmoStat/autometacal/issues/4#issue-809351133 we also probably want to have access to PSF and noise information for metacal, do you want to include those as separate stages and not in the dataset? For the noise I think it makes sense, but for the PSF we might want to have PSF info as part of the dataset as well... idk

andrevitorelli commented 3 years ago

Committed the changes to this branch, waiting for review. @EiffL A few things do not work with the metacal function as it is now.

EiffL commented 3 years ago

Well.... Maybe if you want to have the Fourier image of the Galaxy image + noise... Maybe what you have here makes more sense

EiffL commented 3 years ago

Hi @andrevitorelli I just did a review and it looks pretty good to me :-) It's a good basis I think for the rest.

I only made a trivial suggestion, but I'm very happy with merging this

andrevitorelli commented 3 years ago

Done!

andrevitorelli commented 3 years ago

Uhm, @EiffL do I keep the branch for documentation reasons? Idk

EiffL commented 3 years ago

Hummmm as you wish. Its whole history is merged in master anyway