search

CosmoStat / autometacal

Metacalibration and shape measurement by automatic differentiation
MIT License
4 stars 1 forks source link

tf ngmix #32

Closed andrevitorelli closed 2 years ago

andrevitorelli commented 2 years ago

Smaller PR to solve #28

EiffL commented 2 years ago

Ok, I've fixed some trivial issues, but still remains some bugs in create_gmix at least... maybe in other places.

I've updated the test to test the compiled tf.function

EiffL commented 2 years ago

Looks good André :-) can you confirm that the test still runs without problem? I don't have a computer with me right now. If tests pass, we'll be able to merge

EiffL commented 2 years ago

@andrevitorelli ?

andrevitorelli commented 2 years ago

@andrevitorelli ?

tf_ngmix and metacal tests pass here, model_fitting doesn't, it crashes.

EiffL commented 2 years ago

Ok well I don't know what happens, but it's unrelated to this PR