CosmoStat / autometacal

Metacalibration and shape measurement by automatic differentiation
MIT License
4 stars 1 forks source link

Adds testing script to compare against ngmix #37

Closed EiffL closed 2 years ago

EiffL commented 2 years ago

This adds a comparison to https://github.com/esheldon/ngmix/blob/9910e9297525d6fafb9a41fac43a91b5d4ef4b37/examples/metacal/metacal.py

Also reverts back to standard ellipticity definition for easier direct comparison to ngmix

EiffL commented 2 years ago

@andrevitorelli could you add as an option to this script to run autometacal in "finite diff" mode?

This is quite useful actually to figure out where problems can come from.

andrevitorelli commented 2 years ago

@andrevitorelli could you add as an option to this script to run autometacal in "finite diff" mode?

This is quite useful actually to figure out where problems can come from.

Yes, sure. I have it coded in a separate but local branch. Later today I'll push this to origin. But, just as a comment, I reintroduced my finitediff function to the metacal.py module to do it.

andrevitorelli commented 2 years ago

@EiffL , I'll close this as soon as I output individual shape measurements from the finitediff function.