search

CosmoStat / wf-psf

Data-driven wavefront-based PSF modelling framework.
MIT License
19 stars 9 forks source link

Make a Pull Request Template #105

Closed jeipollack closed 8 months ago

jeipollack commented 11 months ago

This task is to make a Pull Request Template similar to the one in the ShapePipe Repo.

Add to the checklist a sentence about Validation Tests passing. Add a section instructing where to copy the Validation Test Report.

It should be saved in the corresponding .github directory. It should load automatically in the issue when someone opens a Pull Request. Read more in this Github Blog.

jeipollack commented 11 months ago

Updated description with the task of adding the Validation tests to the Pull Request Template.

nadamoukaddem commented 11 months ago

Is it possible to test if it opens automatically when someone creates a pull request before it is merged into the default branch?

jeipollack commented 11 months ago

you can fork the project to your GitHub repo and test there.

jeipollack commented 9 months ago

@sfarrens After my recent experience, I was thinking that it would be a good idea to require a minimum percentage in unit coverage of 70% for each PR.

What do you think? Is this too strong a requirement and perhaps should be lowered to 60% or 50%?