search

CosmoStat / wf-psf

Data-driven wavefront-based PSF modelling framework.
MIT License
19 stars 9 forks source link

Bug plotting missing Shape Metrics e2 and R2 #111

Closed jeipollack closed 8 months ago

jeipollack commented 10 months ago

Closes #110 and #94

Refactored the ShapeMetricsPlotHandler to reduce duplicated lines, and altered the sequence of commands to produce plots for e1, e2, and R2 shape metrics (see plots below).

This PR also applies a fix raised in https://github.com/CosmoStat/wf-psf/issues/92 regarding skipped validation tests. We want the validation tests to be skipped during CI, but to be ran manually with pytest by the developer. We applied the conditional pytest.mark.skipif decorator and will check if the CI environment variable was defined. If yes, the test is skipped, else the test is run.

Note, 28 files were changed due to rebase with the develop branch with updated package dependencies.

Below I show examples of the Shape metric plots for e1, e2 and R2/MeanR2.

test_metrics_nstars_1000_500_200_Shape_E1_RMSE

<img src="https://github.com/CosmoStat/wf-psf/assets/15669942/ee5e7b6b-0070-4eac-a4e8-2d91b37eaabe" alt="test_metrics_nstars_1000_500_200_Shape_R2_MEANR2_RMSE" width="500">

test_metrics_nstars_1000_500_200_Shape_E2_RMSE
jeipollack commented 9 months ago

@sfarrens I am ready for you to review this PR:

sfarrens commented 9 months ago

Looks OK to me @jeipollack!