CosmoStat / wf-psf

Data-driven wavefront-based PSF modelling framework.
MIT License
19 stars 9 forks source link

Feature refactor UI #53

Closed jeipollack closed 1 year ago

jeipollack commented 1 year ago

This PR features many changes which I subdivide into major and minor categories:

Major

Minor Changes

jeipollack commented 1 year ago

oops. I just remembered that I need to write a method to verify that the config parameters are correct.

sfarrens commented 1 year ago

Thanks @jeipollack, I will start reviewing this tomorrow. :)

jeipollack commented 1 year ago

Thanks, @sfarrens. I am reviewing myself, too! I see that I need to tidy up the io.py module. And, since the construction of the output file directory is automatic I was thinking to convert it to internal commands. If you have any thoughts on that, let me know. Thanks!

jeipollack commented 1 year ago

Hi @sfarrens , I pushed doc string style changes for read_config.py.

jeipollack commented 1 year ago

Hi @sfarrens, just want to send you a FYI that I did a few more changes in this branch more related to restructuring the package, but I did not push them. Instead I decided to checkout a new branch to continue development there until this PR can be merged to the dummy_main branch.