Refactor psf models - Githubissues

CosmoStat / wf-psf

Data-driven wavefront-based PSF modelling framework.

MIT License

19 stars 9 forks source link

Refactor psf models #55

Closed jeipollack closed 1 year ago

jeipollack commented 1 year ago

Major Changes in this PR:

Reorganization of most of the modules to associated packages (script_utils.py will be made deleted in the future) associated to issues: #44 and #46
Added modules for parametric and semi parametric PSF models
Added training_preprocessing.py module with handlers for Training and Test data

Modules to be reviewed:

wf_psf/data/training_preprocessing.py
wf_psf/training/train.py

jeipollack commented 1 year ago

lots of commits bc I forgot I need to use my personal access token to git push from JZ.

jeipollack commented 1 year ago

Hi @sfarrens , I am ready for you to complete your review of train.py and the rest of this PR. The refactoring resulted in changes to configs/training_config.yaml and additional attributes to psf_models/psf_model_semiparametric.py.

jeipollack commented 1 year ago

PR Msg to test GH -> Slack.

jeipollack commented 1 year ago

ah I won't receive a notification bc I sent it.

jeipollack commented 1 year ago

hi @sfarrens I believe I've addressed all your comments and those by @tobias-liaudat on change some config variable names. Re-ran the code and all is good.