search

CosmoStat / wf-psf

Data-driven wavefront-based PSF modelling framework.
MIT License
19 stars 9 forks source link

Bug Fix: Replacing Old Adam Optimizer with Legacy Optimizer #93

Closed nadamoukaddem closed 9 months ago

nadamoukaddem commented 9 months ago

Bug Fix for Issue #88

Validation Tests:

train_test.py

======================================= test session starts ========================================
platform linux -- Python 3.10.12, pytest-7.4.3, pluggy-1.3.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /content/drive/MyDrive/Github/wf-psf
configfile: pyproject.toml
plugins: cases-3.8.1, raises-0.11, black-0.3.12, cov-4.1.0, emoji-0.2.0, xdist-3.5.0, typeguard-2.13.3, anyio-3.7.1
collected 2 items                                                                                  

src/wf_psf/tests/train_test.py::BLACK PASSED 😃                                              [ 50%]
src/wf_psf/tests/train_test.py::test_train[training_params0] PASSED 😃                       [100%]

metrics_test.py


======================================= test session starts ========================================
platform linux -- Python 3.10.12, pytest-7.4.3, pluggy-1.3.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /content/drive/MyDrive/Github/wf-psf
configfile: pyproject.toml
plugins: cases-3.8.1, raises-0.11, black-0.3.12, cov-4.1.0, emoji-0.2.0, xdist-3.5.0, typeguard-2.13.3, anyio-3.7.1
collected 5 items                                                                                  

src/wf_psf/tests/metrics_test.py::BLACK PASSED 😃                                            [ 20%]
src/wf_psf/tests/metrics_test.py::test_eval_metrics_polychromatic_lowres[training_params0] PASSED 😃  [ 40%]
src/wf_psf/tests/metrics_test.py::test_evaluate_metrics_opd[training_params0] SKIPPED 🙄     [ 60%]
src/wf_psf/tests/metrics_test.py::test_eval_metrics_mono_rmse[training_params0] SKIPPED 🙄   [ 80%]
src/wf_psf/tests/metrics_test.py::test_evaluate_metrics_shape[training_params0] SKIPPED 🙄   [100%]
jeipollack commented 9 months ago

@nadamoukaddem Your pull request is incomplete because you did not run the test that would show that the error that was reported by Ezequiel was solved.

Updated my comment bc I made an error missed some info you provided up top (apologies).

jeipollack commented 9 months ago

This PR isn't needed anymore because we changed the version of Keras to a lower compatible one that removes this error.