CosmosContracts / bounties

MIT License
25 stars 12 forks source link

I claim reward for bounty 1 and 2 #19

Closed catShaark closed 1 year ago

catShaark commented 2 years ago

I posted my source codes publicly in this issue https://github.com/CosmosContracts/bounties/issues/17. The first version of the contract is in here. I completed and published it on march 17th. Then I made a better version of the contract here which I completed 5 days later.

Those contract codes provide the solution for osmo bounty 1 and 2. Bounty 3 is not complete yet because it is hard to measure exactly the pool reward on osmosis at each epoch

giansalex commented 2 years ago

A rule has been defined and the challenges can only be completed, when deployed on mainnet , @JakeHartnell or has this changed?

My initial contracts were deployed on feb 25th

query price https://blueprints.juno.giansalex.dev/#/transactions/9785A116F7A10C3E759039D10CAC0C6D84AF943867953CE3FA321A68390D1532

swap, liquidity https://blueprints.juno.giansalex.dev/#/transactions/1D92F49E1E6FA2ECD291AADE6E0997A1E0441BA6025FEDE518F80148C1688465

I have been working on this for quite some time, initially with a native ibc module as suggested by Jake, and later with contracts because osmosis supports it. Ibc module

I have been checking all the necessary steps to get the osmos proposal approved, making a fully functional contract for anyone (including a basic UI). I will publish a draft of the proposal today or tomorrow

** regardless of who wins the challenges, i think everyone should receive rewards from Junohacks.

catShaark commented 2 years ago

A rule has been defined and the challenges can only be completed, when deployed on mainnet , @JakeHartnell or has this changed?

My initial contracts were deployed on feb 25th

query price https://blueprints.juno.giansalex.dev/#/transactions/9785A116F7A10C3E759039D10CAC0C6D84AF943867953CE3FA321A68390D1532

swap, liquidity https://blueprints.juno.giansalex.dev/#/transactions/1D92F49E1E6FA2ECD291AADE6E0997A1E0441BA6025FEDE518F80148C1688465

I have been working on this for quite some time, initially with a native ibc module as suggested by Jake, and later with contracts because osmosis supports it. Ibc module

I have been checking all the necessary steps to get the osmos proposal approved, making a fully functional contract for anyone (including a basic UI). I will publish a draft of the proposal today or tomorrow

** regardless of who wins the challenges, i think everyone should receive rewards from Junohacks.

I think it should go like this. First implement a valid solution for the problems, opensource the code so that people can review it, once they decide the code is good enough, deploy it on mainnet.

Logically, that should be the case. Since the bounty is big, the code should be perfect. That's exactly why @JakeHartnell requires multiple iterations of the contract, so that at each version, the code comes out better and better. You can't just deploy every iterations of the contract to osmosis mainnet. This explain why I published the code but haven't deploy it yet, cause I want a quality and solid solution that is worth paying for.

Deploying a closed source contract on testnet leadact on testnet leas us nowhere, not useful for the community at all. The way I see it, it It's like an attempt to claim the reward without actually contributing the code. I can't find any other reasons to not publish the code unless you @giansalex convince me otherwise.

giansalex commented 2 years ago

I completely agree, i have been refactoring the code, adding more tests, before making it public, i have even found several issues that have been reported or requested to me.

i will not deploy to mainnet yet, i will just create the draft and post the code there, open for review, and also set up the UI for users to test.

catShaark commented 2 years ago

What is the point of showing your initial contract when your osmo node is local and your contract is closed source then. Also, to be honest with you, I suspect that you use the code I published for your contract. Isn't it convenient that 8 days after I opened my repo, you deployed a different contract from your original one to osmo testnet.

catShaark commented 2 years ago

@giansalex , plz do it immediately, you just replied my comment so you might as well prove yourself right now

giansalex commented 2 years ago

If you think that, it's because you don't know me, when you published your issue °17, i had already deployed the contracts weeks before, but I was doing other things at the time.

catShaark commented 2 years ago

A closed contract means nothing, anyone can put up a fake demo. Only actual working code is worth showing

catShaark commented 2 years ago

I don't know you, that's why I suspect you. Just show your code plz

giansalex commented 2 years ago

A closed contract means nothing, anyone can put up a fake demo. Only actual working code is worth showing

of course, I will just say that I kept my original proposal to use the middleware approach, and I think you were using ica

catShaark commented 2 years ago

Yes I was using ica. But I came up with a better solution, implemented the code, published it so that people can review it and pointing out what is missing for the sake of improvement. Is there anything wrong or irrational with that?

catShaark commented 2 years ago

Also, why refactoring now all of the sudden. Didn't you just deploy your contract to the testnets 8 days ago, why refactoring now

catShaark commented 2 years ago

Are you trying to refactor so that yours doesn't look like mine. See, the thing here is that I have nothing personal to do this to you, as you stated before, I don't know you. It just that all the actions you did can only be explained by you using my code for your credit. My opinions toward you are fact based

JakeHartnell commented 2 years ago

No need to argue friends, I think for this challenge there can be multiple winners.

catShaark commented 2 years ago

I'm just accusing him of using pieces of my code for his contract. These pieces of code are tricky, it took a lot of my time and work, and are basically on of the most important keys to solve the challenge (I'm talking about stargate query and stargate transaction). He can prove otherwise by showing his original code right now, just that simple. But haven't seen anything so far.

catShaark commented 2 years ago

blockchain history doesn't lie, obviously I used stargate, because it's the only way. I can prove that I have been using coswasm stargate since long before, i even found a vulnerability.

I agree with you that blockchain history doesn't lie, plz provide proof using blockchain history. Thanks

JakeHartnell commented 1 year ago

Closing for now, partially paid out as this was a good effort for a very difficult challenge. Looking forward to what you do next!