search

CosmosOS / Cosmos

Cosmos is an operating system "construction kit". Build your own OS using managed languages such as C#, VB.NET, and more!
https://www.goCosmos.org
BSD 3-Clause "New" or "Revised" License
2.91k stars 549 forks source link

Visual Studio Workloads not found. Install .NET Core cross-platform development, Visual Studio Extension development #1626

Closed emanueleriboldi closed 9 months ago

emanueleriboldi commented 3 years ago

======================================== Builder Log

======================================== Checking Dependencies

Repos: IL2CPU, XSharp and Common is installed. Visual Studio 15.9+ is installed. Visual Studio Workloads not found. Install .NET Core cross-platform development, Visual Studio Extension development,

======================================== Error

Visual Studio Workloads not found.

But i installed .NET Core cross-platform development,.NET Core dev kit Immagine 2021-01-07 075600

Immagine 2021-01-07 075633

and Visual Studio Extension development!

quajak commented 3 years ago

This seems to be connected to https://github.com/CosmosOS/Cosmos/issues/1603 in that, we as soon as multiple vs installations the check breaks. If you are installing the devkit, the easiest way would be to simply disable to check in the local installation, for an actual fix, the two solutions I can think of are 1) detect if there is more than 1 vs installation, disable check but warn user or 2) always warn the user if the check did not succeed but let the installation continue, even if they arnt installed, as it will break at some later point.

jp2masa commented 3 years ago

Maybe the check for multiple VS instances is not working, it should show a dialog to select the target instance:

https://github.com/CosmosOS/Cosmos/blob/86dfa0879f882e6a9c09557ad080cb8a694d6961/source/Cosmos.Build.Builder/App.xaml.cs#L56-L76

emanueleriboldi commented 3 years ago

This seems to be connected to #1603 in that, we as soon as multiple vs installations the check breaks. If you are installing the devkit, the easiest way would be to simply disable to check in the local installation, for an actual fix, the two solutions I can think of are 1) detect if there is more than 1 vs installation, disable check but warn user or 2) always warn the user if the check did not succeed but let the installation continue, even if they arnt installed, as it will break at some later point.

Of course! I had 2 visual studio! Thanks very much, now is working!

quajak commented 3 years ago

This issue should stay open until we fix the underlying issue.

Maybe the check for multiple VS instances is not working, it should show a dialog to select the target instance:

https://github.com/CosmosOS/Cosmos/blob/86dfa0879f882e6a9c09557ad080cb8a694d6961/source/Cosmos.Build.Builder/App.xaml.cs#L56-L76

Thanks, that seems the likely culprit.

emanueleriboldi commented 3 years ago

This issue should stay open until we fix the underlying issue.

Maybe the check for multiple VS instances is not working, it should show a dialog to select the target instance: https://github.com/CosmosOS/Cosmos/blob/86dfa0879f882e6a9c09557ad080cb8a694d6961/source/Cosmos.Build.Builder/App.xaml.cs#L56-L76

Thanks, that seems the likely culprit.

Ok

github-actions[bot] commented 3 years ago

Stale issue message