search

CosmosOS / Cosmos

Cosmos is an operating system "construction kit". Build your own OS using managed languages such as C#, VB.NET, and more!
https://www.goCosmos.org
BSD 3-Clause "New" or "Revised" License
2.94k stars 552 forks source link

Revert Misha's commit for GCImpl #2853

Closed RaphProductions closed 11 months ago

RaphProductions commented 11 months ago

The commit made by Misha 2 weeks ago broke the 'Cosmos.Core.Memory.Heap.Collect()' function. This commit aims to revert these changes

valentinbreiz commented 11 months ago

What did it broke? It seems to work for me

RaphProductions commented 11 months ago

Heap.Collect

RaphProductions commented 11 months ago

When i tried Mirage with the latest commit, it froze on the setup screen.

GoldenretriverYT commented 11 months ago

Yeah there are some issues with Heap.Collect on the latest commit, but were you able to actually verify that it was that commit? Just because it changed the GC code doesn't meant it has to be that commit, so please make sure it was actually this commit.

RaphProductions commented 11 months ago

I reverted back the GCimpl code on my local version, and it works again

ADev531 commented 11 months ago

it, works for me and i can use gui os over than 10 minutes

9xbt commented 11 months ago

don't blame misha, it's just that the gc is shit but i mean if you optimize your os which i really did with mango it will run just fine, no fps drop

RaphProductions commented 11 months ago

don't blame misha, it's just that the gc is shit but i mean if you optimize your os which i really did with mango it will run just fine, no fps drop

I didn't blame Misha, they are doing really good work, but Heap.Collect now crashes the OS

RaphProductions commented 11 months ago

I mean, everyone can break everything

quajak commented 11 months ago

We might need to readd some code like the original one to prevent the heap from being on top of kernel code. But I think we removed this code to fix https://github.com/CosmosOS/Cosmos/issues/2546. Therefore, we should try find a solution which fixes both issues, rather than just reintroduce the old one

pleasenoban commented 11 months ago

i dont think this stops it from overriding the acpi tables though?