search

CosmosOS / Cosmos

Cosmos is an operating system "construction kit". Build your own OS using managed languages such as C#, VB.NET, and more!
https://www.goCosmos.org
BSD 3-Clause "New" or "Revised" License
2.94k stars 552 forks source link

Fixing a patch #2959

Closed PratyushKing closed 9 months ago

PratyushKing commented 9 months ago

There was a recent commit by @valentinbreiz, that commit changed the copy paths of IL2CPU artifacts from Debug to Release which is not working as of right now on any current linux device and this pull request will revert it back to when it worked, This makes sure that there are no errors during the general build process.

9xbt commented 9 months ago

I would discard any changes to any .lock.json file before making the PR and I would also add an option to switch between debug and release instead of undoing the changes to a coredev

PratyushKing commented 9 months ago

I would discard any changes to any .lock.json file before making the PR and I would also add an option to switch between debug and release instead of undoing the changes to a coredev

Well, I wasn't sure about it either so I have enabled to allow edits according to coredevs so its entirely modifyable

selkij commented 9 months ago

Already done in #2897 I will finish this when I have time in the week

9xbt commented 9 months ago

LMFAO

selkij commented 9 months ago

consider this PR useless also you should continue your minecraft gameplay it was so interesting and also the python tutorial damn your voice makes me wanna eat spicy strawberries

selkij commented 9 months ago

and also we don't use Debug but Release so it's even more useless

zarlo commented 9 months ago

okay this is some thing that keeps breaking i thing we should just set the out put paths just to be done with it

PratyushKing commented 9 months ago

consider this PR useless also you should continue your minecraft gameplay it was so interesting and also the python tutorial damn your voice makes me wanna eat spicy strawberries

there was no voice.....

PratyushKing commented 9 months ago

also yeah ill just keep it closed until theres something fixed, i anyways just update my own repo for changes and use fork