search

CosmosOS / Cosmos

Cosmos is an operating system "construction kit". Build your own OS using managed languages such as C#, VB.NET, and more!
https://www.goCosmos.org
BSD 3-Clause "New" or "Revised" License
2.91k stars 549 forks source link

NAsm MSBuild task interpret warning as error #50

Closed kant2002 closed 9 years ago

kant2002 commented 9 years ago

When building Demos\Guess\Guess project following error produced.

1>C:\Program Files (x86)\MSBuild\Cosmos\Cosmos.targets(45,5): error : C:\Users\Documents\GitHub\Cosmos-1\Demos\Guess\bin\Debug\Guess.asm:1964: warning: trailing garbage after `%endif' ignored

From what I see is that NAsm output incorrectly interpresed by Cosmos.Build.MSBuild.Nasm task

kant2002 commented 9 years ago

This is produced by commit https://github.com/CosmosOS/Cosmos/commit/e614a95df51524004e5dc0aa448059bfe36be345#diff-6038801f6586bf84d86a43b516e6b6d7L126

which is remove processing logic for output messages produced by the tools

mterwoord commented 9 years ago

That code caused issues with IL2CPU i think, therefore it was removed.. You could add it again if you test it well...

2015-01-15 7:47 GMT+01:00 Andrey Kurdyumov notifications@github.com:

This is produced by commit e614a95#diff-6038801f6586bf84d86a43b516e6b6d7L126 https://github.com/CosmosOS/Cosmos/commit/e614a95df51524004e5dc0aa448059bfe36be345#diff-6038801f6586bf84d86a43b516e6b6d7L126

which is remove processing logic for output messages produced by the tools

— Reply to this email directly or view it on GitHub https://github.com/CosmosOS/Cosmos/issues/50#issuecomment-70046372.

kant2002 commented 9 years ago

What if I revert back code and for IL2CPU task put pass-through logic which will mimic current behavior? That way I less likely introduce regression.

mterwoord commented 9 years ago

OK, Go ahead!

2015-01-15 11:06 GMT+01:00 Andrey Kurdyumov notifications@github.com:

What if I revert back code and for IL2CPU task put pass-through logic which will mimic current behavior? That way I less likely introduce regression.

— Reply to this email directly or view it on GitHub https://github.com/CosmosOS/Cosmos/issues/50#issuecomment-70064056.

kant2002 commented 9 years ago

Does Kudzu.Breakpoints and SentinelKernelBoot was compiling? They report that plugs are missing. Is this something expected?

mterwoord commented 9 years ago

Only compilation issue we know of (is fixed in my latest commit) is a missing file in the DebugCompiler project. Nothing else. Are you on a clean build?

kant2002 commented 9 years ago

Pull request is here: https://github.com/CosmosOS/Cosmos/pull/52

kant2002 commented 9 years ago

Yes I'm on clean build. Even revert all changes. I was compiling Cosmos projects. Don't have any issues with C#

ghost commented 9 years ago

I'll verify my project. Will be about 2 hours until I can do it.

ghost commented 9 years ago

SentinelKernel compiles and runs without issues. There is the nasm warning thugh which I would expect.

kant2002 commented 9 years ago

We resolved there. Right now no errors happens. Pull request could be merged