Networking Improvments (Drop unknown packets & don't hang if unable to connect to server)

CosyClub / ProjectTempo

Rave Cave, A rhythm based MMO where players rock out together!

3 stars 0 forks source link

Networking Improvments (Drop unknown packets & don't hang if unable to connect to server) #117

Closed AnthonyWharton closed 6 years ago

AnthonyWharton commented 6 years ago

Says what it does in the title. Please can this be checked on Windows by @qqii or @grant-m-s (or @jnterry?)

Fixes: #36, #100

Feel free to delete this branch once merged.

AnthonyWharton commented 6 years ago

Actually also, probably worth testing on lab machines as I've only tested this locally..

qqii commented 6 years ago

Does this also close #98?

qqii commented 6 years ago

Since it is directly relevant, can we get an updated README.md with instructions about how to use it on a lab machine (to connect)?

qqii commented 6 years ago

On a single lab machine here's what I've tested:

Loading the client then the server allows the client to connect.
Connecting two players is fine, there is latency but I am able to play the game from the other screen.
Connecting a client to a server then crashing the server leave the client bouncing, restarting the server does not fix this.
Repeatedly connecting the client and then disconnecting from the server leaves the client disconnected.

I'd like to test this on Windows, but apart from not building that's not a high priority concern. I don't have explicit instructions for what this should fix and I've never ran it on multiple machines.

Camera FOV is something to investigate: #119

qqii commented 6 years ago

Instructions for Lab Machine:

Pull the repo and navigate to the root folder. Then run:
mkdir build
cd build
cmake ..
make [-j8]
cd ../bin/
Now you need your IP address, for that run ifconfig and look for the IPv4 address under eno1, it should be something like 137.222.xxx.xxx ish...
Now run the server on one machine with ./RaveCave_Server
Now run the client on any machine in the lab with ./RaveCave [ip_address]
Et voila! You should be good to go :slightly_smiling_face:

-Anthony

RcColes commented 6 years ago

I'm unconvinced by having the readme change in here, as it's fundamentally a separate issue. It should have another github issue and PR created for it.

AnthonyWharton commented 6 years ago

Paging @qqii for updating review. The issue on the lab machines was not having the new ports merged in.