search

CosyClub / ProjectTempo

Rave Cave, A rhythm based MMO where players rock out together!
3 stars 0 forks source link

Fixed GCC Warnings #153

Closed AnthonyWharton closed 6 years ago

AnthonyWharton commented 6 years ago

Just rebuilding now to test, please do a clean build and check that our stuff isn't creating any more warnings.

For some reason when building clean I noticed that the irrlicht demo's returned.. can't work out why as it came from master and the last time I built master it didn't have the demo's... If you have any ideas please let me know :stuck_out_tongue:

grant-m-s commented 6 years ago

on windows they come back until you make a change that affects one of the cmake files (or sometimes when vs crashes) then they disappear no idea why

AnthonyWharton commented 6 years ago

Makes no sense as the option to include them is off in extlibs/CMakeLists.txt ....

AnthonyWharton commented 6 years ago

Finished the build on my machine, seems to be all good.

grant-m-s commented 6 years ago

:man_shrugging:

grant-m-s commented 6 years ago

are you planning on merging #118 into this now?

AnthonyWharton commented 6 years ago

Sorry missed that comment @grant-m-s .. Not sure on the status on #118 so I was leaving it for now..

AnthonyWharton commented 6 years ago

Change of heart, it's rendering code and shouldn't set state - It was working with the unnecessary line before, so yup..

jnterry commented 6 years ago

@grant-m-s @AnthonyWharton The irrlicht examples building is controlled by a cmake option, if you run cmake-gui in the build directory you can check or uncheck the option "TEMPO_BUILD_IRRLICHT_EXTRAS". Saying that, I have no idea why it would randomly turn itself on...

Regardless, this code works, I see now warnings, merging...