search

CosyClub / ProjectTempo

Rave Cave, A rhythm based MMO where players rock out together!
3 stars 0 forks source link

Refactor combo growth #188

Open qqii opened 6 years ago

qqii commented 6 years ago

Move combo growth into its own system

AnthonyWharton commented 6 years ago

Why? Combo growth should be handled by the helper functions in the component..

qqii commented 6 years ago

Combo height is in SystemRenderComponent and uses the hasComponent function. It doesn't play well with the rest of the general code from #164.

AnthonyWharton commented 6 years ago

Sorry I have no idea what you're talking about.. What SystemRenderComponent?

qqii commented 6 years ago

I meant SystemRenderSceneNode, which should be more aptly named SystemRenderBillboards.

AnthonyWharton commented 6 years ago

Agree on the rename. So you're talking about the growing size of a player with the combo? This was something that was implemented in the middle of a mid-term demo as an example so it wasn't exactly pretty code.

Again I think this is covered by the, would be nice, but we have lots of deadlines and a report to write.

qqii commented 6 years ago

I think this is needed to prevent floating billboards.