search

Cotix / cReddit

CLI Reddit client written in C. Oh, crossplatform too!
Other
96 stars 14 forks source link

A .creddit would be slightly more secure method of storing username and password #54

Open gridsystem opened 10 years ago

gridsystem commented 10 years ago

I'm not keen on having my username and password in my bash history. I'd be happier if it could just be stored plaintext somewhere so that when I'm searching for a previous command with up/down at the prompt it can't be seen.

mkilgore commented 10 years ago

I would agree with everything you've added. cReddit isn't to far along right now, so without just hacking up some functionality to read a very basic config file that'll get replaced I don't really see much of a fix for it just yet. At the moment logging in is more of a test of that feature then it is really useful, but I do see why it's an obvious security issue. cReddit is (hopefully) going to have a basic config file that it reads soon, and in there you can place your username (And password if wanted). I can't say if any encryption would be done, but If it's that big of a worry, you can just leave your password out of the config and type it in on launch.

But I could easily add a prompt for a password when the program starts-up if you don't include your password in the arguments, That seems like a good solution for the time being. Leaving your username in your bash history isn't great, but compared to leaving your password there it's not bad. That's dead simple to do, so I'll write-up a patch for it later-on today.

gridsystem commented 10 years ago

Any of those solutions would be great. It sounds like having a password prompt would save you having to encrypt credentials for those not wanting to store in plain-text once the project has matured so I think that's an excellent idea.

mkilgore commented 10 years ago

Sounds good, I'll implement a simple password prompt.