search

Cotix / cReddit

CLI Reddit client written in C. Oh, crossplatform too!
Other
96 stars 14 forks source link

Adds scrolling to text in links/comments pane. Adds date to link and comment. Rebuild screen after closing opened link #76

Closed stoicism2323 closed 8 years ago

stoicism2323 commented 8 years ago

The 'rebuild screen after closing opened link' part only is a step in the right direction it seems. The part I'm referring to is the added lines after the "case 'o'" in showSubreddit(). It's okay to not merge that part if you dont want it.

Thanks!

Cotix commented 8 years ago

Is there a specific reason why advance is still in the link or command structures, and not in the screen structures? Except for that, the code looks good.

stoicism2323 commented 8 years ago

Thanks for the feedback Cotix. I figured that if its in the link and comment structs, then you can:

1 Open any comment in the comment screen 2 scroll down on the text 3 go to some other comment, then go back to the comment in step 1 4 this comment will still be scrolled to where you left it

I believe if the advance variable is in LinkScreen and CommentScreen instead of RedditLink and RedditComment, then when you scroll back to the original comment it'll be scrolled back up to the top. I prefer it remembering the scroll point per comment, but it would save lots of space if it's in LinkScreen and CommentScreen so if you want it to be changed that makes sense :).

Cotix commented 8 years ago

I guess that makes sense. I'll merge this then.