CotripperPlatform / CoTrip

GA Development
3 stars 12 forks source link

Header is fixed #577

Closed rmfortes closed 4 years ago

rmfortes commented 4 years ago
  1. When each link is clicked, the user is routed to the appropriate page. (As it is now, 'forum', 'directory', and 'community' will not render because those pages don't exist in my code; once Scott, Dami, and Andrew's code is merged, they will.)
  2. Previously, the drop-down menu was rendering when the user hovered over every component. Now, it only renders when the user hovers over 'community,' as it should.
  3. The purple arrow now follows the user's behavior and renders under the appropriate clicked link. Functionality for that purple arrow lives in the documents for each individual page; once Scott and Dami's code is merged into the project, the purple arrow will follow whatever page the user is on. The purple arrow should not be visible at all when the user is at "/home".
mrrogercampbell commented 4 years ago

Hey @rmfortes, everything looks good to me. The only question I have is with the number 3. I do not see a purple arrow. Can you give me a bit more clarification on that?

mrrogercampbell commented 4 years ago

Also, your branch has two merge conflicts. Can you please resolve those?

rmfortes commented 4 years ago

Fixed! Thanks @clarknoah and @rc1336

rmfortes commented 4 years ago

@rc1336 @clarknoah resubmitted; apologies for the last submish!

clarknoah commented 4 years ago

@rmfortes reviewing now!

clarknoah commented 4 years ago

@rmfortes great stuff, I'm closing out this issue!