Open Bcastillo44 opened 4 years ago
Error: ./src/components/Pill/Pill.js Line 43:15: img elements must have an alt prop, either with meaningful text, or an empty string for decorative images jsx-a11y/alt-text
Added alt description to component./src/components/Pill/Pill.js alt= "Heart-shaped icon"
Error: ./src/components/CarouselDots/CarouselDots.js Line 3:8: 'ReactDOM' is defined but never used no-unused-vars Line 34:11: 'classList' is assigned a value but never used no-unused-vars Line 42:17: Expected '===' and instead saw '==' eqeqeq
Added additional equal sign to component Line 42:17: Expected '===' and instead saw '==' eqeqeq Fixed Line 42:17
Error: ./src/pages/OnboardingPage/FilterSettingsForm/FilterSettingsForm.js Line 46:25: Expected '===' and instead saw '==' eqeqeq
Added additional equal sign to component Fixed Line 46:25: Expected '===' and instead saw '==' eqeqeq
Error: ./src/components/Icon/Icon.js Line 7:32: Expected '===' and instead saw '==' eqeqeq
Added additional equal sign to component Fixed: Line 7:32: Expected '===' and instead saw '==' eqeqeq
Error: ./src/components/Bio/Bio.js Line 124:36: Expected '===' and instead saw '==' eqeqeq
Added additional equal sign to component Fixed: Line 124:36: Expected '===' and instead saw '==' eqeqeq
Error: ./src/services/User.js Line 21:31: Expected '!==' and instead saw '!=' eqeqeq Line 46:31: Expected '!==' and instead saw '!=' eqeqeq
Added additional equal sign to component Fixed Line 21:31: Expected '!==' and instead saw '!=' eqeqeq Line 46:31: Expected '!==' and instead saw '!=' eqeqeq
Error: ./src/pages/OnboardingPage/UserSetupForm/UserSetupForm.js Line 35:34: Expected '===' and instead saw '==' eqeqeq
Added additional equal sign to component Fixed: Line 35:34: Expected '===' and instead saw '==' eqeqeq
Error: Line 196:9, Line 159:9, Line 40:9: The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value.
Fixed: Added href attribute to Line 196:9, Line 159:9, Line 40:9:
Error: ./src/components/Modal/Modal.js Line 15:9: The href attribute requires a valid value to be accessible. Provide a valid, navigable address as the href value.
Fixed: Added "#modal" to href
Error:
./src/components/ProfilePicture/ProfilePicture.js
Line 16:11: Redundant alt attribute. Screen-readers already announce img
tags as an image. You don’t need to use the words image
, photo,
or picture
(or any specified custom words) in the alt prop jsx-a11y/img-redundant-alt
Line 19:9: Redundant alt attribute. Screen-readers already announce img
tags as an image. You don’t need to use the words image
, photo,
or picture
(or any specified custom words) in the alt prop jsx-a11y/img-redundant-alt
Fixed: Removed "picture" from both alt lines. Added more descriptive alt reference - link, user
Error: ./src/pages/ForumPage/ForumPage.js Line 71:13: No duplicate props allowed react/jsx-no-duplicate-props
Fixed: Duplicate sizes "small" and "medium" - commented out size {"medium"} After checking other pages: Directory and Community Page have size “wide” - Need to match sizes on all pages for continuity – Replaced size “medium” and “small” with “wide” and fix CSS
Error: ./src/pages/ForumPage/ForumPageDiscover.js Line 106:13: No duplicate props allowed react/jsx-no-duplicate-props
Fixed: Duplicate sizes "small" and "medium" - commented out size {"medium"} After checking toher pages: Directory and Community Page have size “wide” - Need to match sizes on all pages for continuity – Replaced size “medium” and “small” with “wide” and fix CSS
Error: ./src/pages/ForumPage/ForumPageDiscover.js Line 45:9: The href attribute is required for an anchor to be keyboard accessible.
Fixed: Added href to Line 45:9
Error: ./src/pages/DirectoryPage/DirectoryPeople.js Line 42:9: The href attribute is required for an anchor to be keyboard accessible. Fixed: Added href attribute to Line 42:9,
Opening new issue: Need actual path for href's on Line 148:9, Line 181:9
Error: ./src/pages/CommunityPage/CommunityPage.js Line 49:9: The href attribute is required for an anchor to be keyboard accessible.
Fixed: Added href to Line 49:9
Opening new issue: Need actual path for href's on Line 154:9, Line 241:9
Error: ./src/components/Footer/Footer.js Line 21:45: Using target="_blank" without rel="noopener noreferrer" is a security risk
Fixed: Added rel="opener" in place of target = "_blank"
Error:
./src/pages/HomePage/HomePage.js
Line 152:15: img elements must have an alt prop, either with meaningful text, or an empty string for decorative images
Fixed:
Added alt props to image source:
Line 152:15
Line 158:15
Line 164:15
Line 170:1
Error: ./src/pages/HomePageOldUser/HomePageOldUser.js Line 236:15: img elements must have an alt prop, either with meaningful text, or an empty string for decorative images Fixed: Added alt props to image source: Line 236:15 Line 229:15 Line 223:15
Describe the bug A clear and concise description of what the bug is.
When running the local application with "npm start", the application loads properly, but with many errors that need to be fixed.
To Reproduce Steps to reproduce the behavior:
./src/components/Icon/Icon.js Line 1:16: 'Component' is defined but never used no-unused-vars Line 7:32: Expected '===' and instead saw '==' eqeqeq
./src/services/User.js Line 21:31: Expected '!==' and instead saw '!=' eqeqeq Line 46:31: Expected '!==' and instead saw '!=' eqeqeq
Expected behavior No errors should be running while loading the local server, which is localhost:3000
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context Add any other context about the problem here.