Closed secondaryfun closed 4 years ago
Forgive the misunderstanding re: lists in tables. I found a serializer library for Django's Rest framework that has a nested table write option. The ticket should be fully functional now.
@Underwaterr Do you mind testing this out? I'm sometimes getting an error when I sign in and load the user profile page
@secondaryfun Where did we net out on this one? I think you said you were able to reproduce the error on this branch and on develop?
The error you described is unrelated to this issue. See https://github.com/CotripperPlatform/CoTrip/pull/658 for the fix. @ZakkMan
@ZakkMan This one should be ready to review. The error of the page loading was related to an issue on the app.js page, which I addressed in a separate issue.
The last push required a --force. (git pull went smoothly, but the push still had errors) No errors since the push.
Related Issue (include '#'): https://github.com/CotripperPlatform/CoTrip/issues/422
Description of changes made: On MemberProfilePage:
Social Media Icons now populate from the user profile. toggleEdit now provides text boxes to add social media usernames. Social media options are populated based on Social_media_type table. ** On submit, urls are added to user profile for each social media option. URLs are generated as follows:
Is the feature complete/bug resolved/etc..: ** The url currently generated assumes a certain pattern for social media sites. Suggest adding a row to the Social_media_type table of: "url_base" . This would be the base url which usernames are added to to reach a user's account. By adding it to the Model, future admins can add or change the base URL, if future social media sites do not fit the current pattern.
*** Larger issue: Links to an outside side take users away from the core functionality of the site and encourage users to connect elsewhere. I would suggest modifying this functionality to enable direct posting of messages/likes/etc. from the CoTripper account to outside social media accounts, thereby keeping the user within the CoTripper system.
Any known bugs/strange behavior:
Is there specific feedback you would like on these changes:
Screenshot(s):