CotripperPlatform / CoTrip

GA Development
3 stars 12 forks source link

User account add social media links #646

Closed secondaryfun closed 4 years ago

secondaryfun commented 4 years ago

*** Larger issue: Links to an outside side take users away from the core functionality of the site and encourage users to connect elsewhere. I would suggest modifying this functionality to enable direct posting of messages/likes/etc. from the CoTripper account to outside social media accounts, thereby keeping the user within the CoTripper system.

secondaryfun commented 4 years ago

Forgive the misunderstanding re: lists in tables. I found a serializer library for Django's Rest framework that has a nested table write option. The ticket should be fully functional now.

0xZakk commented 4 years ago

@Underwaterr Do you mind testing this out? I'm sometimes getting an error when I sign in and load the user profile page

0xZakk commented 4 years ago

@secondaryfun Where did we net out on this one? I think you said you were able to reproduce the error on this branch and on develop?

secondaryfun commented 4 years ago

The error you described is unrelated to this issue. See https://github.com/CotripperPlatform/CoTrip/pull/658 for the fix. @ZakkMan

secondaryfun commented 4 years ago

@ZakkMan This one should be ready to review. The error of the page loading was related to an issue on the app.js page, which I addressed in a separate issue.

0xZakk commented 4 years ago

658 has to be merged before this one can be

secondaryfun commented 4 years ago

The last push required a --force. (git pull went smoothly, but the push still had errors) No errors since the push.