search

CottageLabs / OpenArticleGauge

Software for the OpenArticleGauge service
http://www.howopenisit.org
Other
7 stars 5 forks source link

handle SSL errors in badly set up servers #104

Open richard-jones opened 10 years ago

richard-jones commented 10 years ago

doi: 10.5007/2175-8077.2011v13n30p249

resolves to: https://www.periodicos.ufsc.br/index.php/adm/article/view/20275

But on connection in a browser we are warned about the SSL certificate. This needs to be handled in one of two ways:

1/ Catch the SSLError and record a proper error against the record in OAG 2/ Ignore (is that wise?) warnings about SSL certificates

emanuil-tolev commented 10 years ago

Yeah, it's fine to ignore. Basically: do you care about the integrity of the data? Publishers' servers can serve us bollocks if they want to anyway. This is far more likely to be a misconfigured server than a man-in-the-middle attack to ... what, falsify license info :)? Will ignore.

emanuil-tolev commented 10 years ago

(Obviously passwords and other sensitive things being transmitted is a case where you would care.)

richard-jones commented 10 years ago

In which case I may already have fixed this - there was a problem with the error reporting when there were SSLErrors, so I put in a fix to serialise the errors properly. That should mean that errors get properly recorded in the cache, but hasn't been tested in the wild yet.