CottageLabs / uniboard

UniBoard project
0 stars 0 forks source link

Sense check pricing #65

Closed richard-jones closed 10 years ago

richard-jones commented 10 years ago

When a price hits a value X, the create form should offer a pop-up warning to the user which will allow them to go back and change the price. X to be configurable.

Nimphal commented 10 years ago

What should X be right now? £60? @mjb295 do you have an opinion on this?

Where should X be configurable from, the admin area?

Nimphal commented 10 years ago

If the price the user enters is above £60 (currently this number can only be changed in the JS code), an alert box pops up asking the user if they are sure they want to set it this high.

richard-jones commented 10 years ago

Can we move the configuration into settings.py to keep it in line with the rest of the site config.

The way to integrate this with the JS front end is to set the content of that config option to a variable in the extra_js_bottom section, like

var price_check = {{config.get("PRICE_CHECK") }}

mjb295 commented 10 years ago

Sorry Nevilina, not sure I understand what you mean? Kind Regards, Matt Beveridge Sent from my BlackBerry® smartphone on O2

-----Original Message----- From: Nimphal notifications@github.com Date: Tue, 5 Aug 2014 09:01:35 To: CottageLabs/uniboarduniboard@noreply.github.com Reply-To: CottageLabs/uniboard reply@reply.github.com Cc: mjb295mjb295@bham.ac.uk Subject: Re: [uniboard] Sense check pricing (#65)

What should X be right now? £60? @mjb295 do you have an opinion on this?

Where should X be configurable from, the admin area?


Reply to this email directly or view it on GitHub: https://github.com/CottageLabs/uniboard/issues/65#issuecomment-51218693

Nimphal commented 10 years ago

Ah, yes, settings.py makes sense, will do.

Matt, I was asking what the limit should be, what is too high a number?

2014-08-05 19:50 GMT+01:00 mjb295 notifications@github.com:

Sorry Nevilina, not sure I understand what you mean? Kind Regards, Matt Beveridge Sent from my BlackBerry® smartphone on O2

-----Original Message----- From: Nimphal notifications@github.com Date: Tue, 5 Aug 2014 09:01:35 To: CottageLabs/uniboarduniboard@noreply.github.com Reply-To: CottageLabs/uniboard reply@reply.github.com Cc: mjb295mjb295@bham.ac.uk Subject: Re: [uniboard] Sense check pricing (#65)

What should X be right now? £60? @mjb295 do you have an opinion on this?

Where should X be configurable from, the admin area?


Reply to this email directly or view it on GitHub: https://github.com/CottageLabs/uniboard/issues/65#issuecomment-51218693

— Reply to this email directly or view it on GitHub https://github.com/CottageLabs/uniboard/issues/65#issuecomment-51242146.

mjb295 commented 10 years ago

If we can do separate sense checking on books and other items then: books £60 is ok and other items £100. If too much hassle, just stick with £100 for either Kind Regards, Matt Beveridge Sent from my BlackBerry® smartphone on O2

-----Original Message----- From: Nimphal notifications@github.com Date: Tue, 5 Aug 2014 11:51:35 To: CottageLabs/uniboarduniboard@noreply.github.com Reply-To: CottageLabs/uniboard reply@reply.github.com Cc: mjb295mjb295@bham.ac.uk Subject: Re: [uniboard] Sense check pricing (#65)

Ah, yes, settings.py makes sense, will do.

Matt, I was asking what the limit should be, what is too high a number?

2014-08-05 19:50 GMT+01:00 mjb295 notifications@github.com:

Sorry Nevilina, not sure I understand what you mean? Kind Regards, Matt Beveridge Sent from my BlackBerry® smartphone on O2

-----Original Message----- From: Nimphal notifications@github.com Date: Tue, 5 Aug 2014 09:01:35 To: CottageLabs/uniboarduniboard@noreply.github.com Reply-To: CottageLabs/uniboard reply@reply.github.com Cc: mjb295mjb295@bham.ac.uk Subject: Re: [uniboard] Sense check pricing (#65)

What should X be right now? £60? @mjb295 do you have an opinion on this?

Where should X be configurable from, the admin area?


Reply to this email directly or view it on GitHub: https://github.com/CottageLabs/uniboard/issues/65#issuecomment-51218693

— Reply to this email directly or view it on GitHub https://github.com/CottageLabs/uniboard/issues/65#issuecomment-51242146.


Reply to this email directly or view it on GitHub: https://github.com/CottageLabs/uniboard/issues/65#issuecomment-51242331

Nimphal commented 10 years ago

I have created two price_check limits in the settings file, but we are currently using only the one for books (£60), because there is no functionality supporting other items yet. When that gets built, we'll see how viable it is to have separate price limits.

richard-jones commented 10 years ago

This is useful - I'm currently working on the non-book items, and I will use your other price_check limit there.

On 6 August 2014 11:39, Nimphal notifications@github.com wrote:

I have created two price_check limits in the settings file, but we are currently using only the one for books (£60), because there is no functionality supporting other items yet. When that gets built, we'll see how viable it is to have separate price limits.

— Reply to this email directly or view it on GitHub https://github.com/CottageLabs/uniboard/issues/65#issuecomment-51318767.

Richard Jones,

Founder, Cottage Labs t: @richard_d_jones, @cottagelabs w: http://cottagelabs.com