CottageLabs / uniboard

UniBoard project
0 stars 0 forks source link

Problems creating adverts for users with no location data #70

Closed richard-jones closed 10 years ago

richard-jones commented 10 years ago

Attempting to create adverts for users who do not have location data in their account, I encountered the following problems:

Fix should be

  1. Disallow selection of "term time residence" when user does not have lat/lon in their account data. OR, force users to have location in their account data (change registration form validation)
  2. Bughunt and fix the "Uni" error
Nimphal commented 10 years ago

If a user with no location data selects My term-time residence, the form will flash them an error with an explanation and suggestion on how to fix it.

I can't seem to replicate the Uni error, though. I have an account with location data with the cottagelabs domain and one without with the brunel domain and both are able to create adverts with Uni location. Could this have had something to do with the change in domain_uni_lookup that I dealt with?

richard-jones commented 10 years ago

Yes, perhaps this error was caused by an inconsistency between the front end and the back end which has now been resolved through other development. If you are confident that the Uni selection now always works, feel free to close off this issue.

richard-jones commented 10 years ago

When the forms are generalised to support other object types, just re-check the uni bug, and make sure it is still cone

richard-jones commented 10 years ago

Re-checked, and everything seems to be working fine