Bring image display in "edit" page into line with "submit" page

[richard-jones]

When an item with an image is edited, the current image is displayed and the "upload new image" button is beneath it (and beneath that is a question asking the user "why not upload an image?" even though they already have).

Can we instead put the image that the user has already uploaded in the #placeholder element and put the upload button above it. This would make it symmetrical with what happens when you upload an image for the first time.

[Nimphal]

I have implemented this suggestion (the two forms in one file threw me in for a loop at first) for both books and other items.

2014-08-18 23:59 GMT+01:00 Richard Jones notifications@github.com:

Assigned #73 https://github.com/CottageLabs/uniboard/issues/73 to @Nimphal https://github.com/Nimphal.

— Reply to this email directly or view it on GitHub https://github.com/CottageLabs/uniboard/issues/73#event-154219191.

[richard-jones]

This doesn't seem to have quite worked - the "other" item page, when you upload an image, does something a bit weird. And the "other" item page also doesn't display an image at all when it is edited. I think this is because the id of the div that does the work is wrong - if you look at the javascript that generates the picture upload stuff, it looks for #placeholder or #general_placeholder, but the latter id now has disappeared, and there are two divs with the id #placeholder.

[Nimphal]

I will investigate. I did get lost in that HTML file a bit, so your suggestion is probably correct. On Aug 20, 2014 9:57 PM, "Richard Jones" notifications@github.com wrote:

This doesn't seem to have quite worked - the "other" item page, when you upload an image, does something a bit weird. And the "other" item page also doesn't display an image at all when it is edited. I think this is because the id of the div that does the work is wrong - if you look at the javascript that generates the picture upload stuff, it looks for

placeholder or #general_placeholder, but the latter id now has

disappeared, and there are two divs with the id #placeholder.

— Reply to this email directly or view it on GitHub https://github.com/CottageLabs/uniboard/issues/73#issuecomment-52842869.

[Nimphal]

This should be fixed now. A few stray divs here and there can really make or break it sometimes.

2014-08-20 21:59 GMT+01:00 Nevelina Aleksandrova nevelina@cottagelabs.com:

I will investigate. I did get lost in that HTML file a bit, so your suggestion is probably correct. On Aug 20, 2014 9:57 PM, "Richard Jones" notifications@github.com wrote:

This doesn't seem to have quite worked - the "other" item page, when you upload an image, does something a bit weird. And the "other" item page also doesn't display an image at all when it is edited. I think this is because the id of the div that does the work is wrong - if you look at the javascript that generates the picture upload stuff, it looks for

placeholder or #general_placeholder, but the latter id now has

disappeared, and there are two divs with the id #placeholder.

— Reply to this email directly or view it on GitHub https://github.com/CottageLabs/uniboard/issues/73#issuecomment-52842869 .

[richard-jones]

Still some stray divs, I think - the "Create My Advert" on the "Other" page is now aligned with the image stuff on the left hand side, rather than at the bottom.

[Nimphal]

Fixed.

2014-08-21 11:31 GMT+01:00 Richard Jones notifications@github.com:

Still some stray divs, I think - the "Create My Advert" on the "Other" page is now aligned with the image stuff on the left hand side, rather than at the bottom.

— Reply to this email directly or view it on GitHub https://github.com/CottageLabs/uniboard/issues/73#issuecomment-52903246.

[richard-jones]

Sorry, I need to re-open this one again one more time. In the case where there is no image associated with an advert, the "why not upload an image" placeholder is not displayed when editing.

[Nimphal]

Should be fixed now.

2014-08-22 12:51 GMT+01:00 Richard Jones notifications@github.com:

Reopened #73 https://github.com/CottageLabs/uniboard/issues/73.

— Reply to this email directly or view it on GitHub https://github.com/CottageLabs/uniboard/issues/73#event-156031052.