Merge of core ores mod

[elesti]

so this merges everything that we had texture/json wise from the core ores mod where we stood was: 100% complete (ores, ingots, blocks, nuggets, dust, and all related json files) cobalt, aluminum, copper, lead, silver, tin, tungsten, uranium, and the missing parts for iron, gold, diamond, emerald (mainly the dusts and recipes)

All the JSON files are created but just missing the appropriate textures for: platinum, palladium, osmium, iridium, plutonium, titanium, ruby, sapphire, peridot, amethyst, topaz, brass, steel, electrum *we did not create alloy ingot recipes we were leaving that to other mods to add so those are missing as well

the list above does not take into consideration anything that you all already had in the repo

please let me know if any of the JSON is still off from what you all need, i have a script i use to regenerate everything, so everything can easily be regenerated.

[elesti]

as for bullets two and three, I expected, they can be discussed further in channel before this gets merged

Bullet one though, I am trying to figure out to which /model/item files you are referring to that are extraneous. As far as I can tell they are all necessary, and at least one version of each already exists in master, unless I am overlooking something or misunderstanding what you are referring to. Can you elaborate as to which files you wish to have removed?

[LemmaEOF]

The assets/models/item/aluminum_block.json and the like aren't needed, since they're not used in the blockstates at all. Feel free to delete the ones for existing materials too.

[elesti]

So I thought that they were needed, so I just checked by assets/models/item/aluminum_block.json out of my core ores mod (since I have the setup to easily run that at the moment vice this mod) and without that file the aluminum_block as displayed in inventory, hand, or thrown on the ground will display as an item without a texture (pink/black box), as soon as it is placed as a block it then gets its block texture. Unless your framework handles this differently those files should be needed. Do you still wish me to remove them?

[LemmaEOF]

That's really weird. I thought they weren't necessary, but I guess they are. Keep 'em in, then.

[LemmaEOF]

I'm OKing for now, but we should def talk more before we merge.

[falkreon]

Most of these assets will have to be redone to avoid the vanilla iron texture and fix palette issues.

The palette before inclusion of core-ores

{
    "copper"   : "ff9800", // "copper_ore": "2ebf83",
    "silver"   : "96b2ff",
    "lead"     : "64536d", //d9bbe9 or ac8fbb are lighter versions
    "zinc"     : "839c94", // ore a1cfc0 (Green hemimorphite)
    "steel"    : "464a57", //achromatic
    "brass"    : "ffbe3a",
    "electrum" : "ffe86d",

    "mercury"  : "ff0000",
    "uranium"  : "65bf43", //achromatic
    "plutonium": "5a5aff", //achromatic
    "thorium"  : "ff3578", //achromatic

    "aluminum" : "f9b9b9", //not officially included
    "coal"     : "4b4b4b",
    "coal_coke": "496262",

    "iron"     : "c2c2c2"
}

Anything added will need to be extremely careful to dodge these colors.

[elesti]

As for the palette colors, I agree that we need to be careful for the colouring, I did not overwrite any of the textures for the ores we shared in common, so there is a likely hood that things are not distinct anymore by colour/pattern. If I were to overwrite everything with what we have, it would be distinct looking, however the quality of our textures may not be as good I do not know (we definitely are not texture artists by trade). When I kick up this mod in game i will set up my little sample display area and I can post images of what everything looks like side by side and we can figure out which things we want to adjust.

[falkreon]

Yeah, having a screenshot of the sample area where we can see, for instance, the white/gray ores next to each other, the blue ores, the orange ores, so we can make color decisions would be extremely helpful. I'm going to do a bunch of texture work when I get home this afternoon, so I think we can get this merged soon(!)