CottonMC / CottonResources

Reference mod for ores, ingots, tools, liquids, and all you can imagine.
MIT License
17 stars 12 forks source link

No Ore Gen 1.14.4 #29

Closed ExoFrece closed 5 years ago

ExoFrece commented 5 years ago

see no ores in the world I can use the ores via the creative tab but that is not the way too play with it

the mods i use: cotton-1.0.0-rc.2 cotton-resources-1.3.3+1.14.3 fabric-api-0.3.0+build.200 LibGui-1.1.0 modmenu-1.6.3+build.101

you need a Log? here is it latest.log

falseresync commented 5 years ago

That means mods don’t request any ore to generate. Since version 1.3 mods have to ask Cotton Resources to generate ores. Please contact mod authors who use Cotton Resources to do that. Say them that they have to use Ore Voting now

ExoFrece commented 5 years ago

thanks for the fast answer :)

This means, for example, the Materialisation mod maker must ask Materialisation for Cotton Resources ore generation?

can i quote you?

falseresync commented 5 years ago

Yeah, kind of. Better say the author to consult Cotton Discord: https://discord.gg/Mr3uWXH

ExoFrece commented 5 years ago

ok have written the Materialisation on github so the problem would be solved thanks a lot for give me your time

falseresync commented 5 years ago

Always glad to help :) Feel free to reopen the issue if it won't be resolved

RViper80 commented 5 years ago

Any way to force it to generate all the ores anyway? Would be nice that way since even if they have no use now, mods could be added to a modpack in the future that use them, and that way worlds would already have them generated in existing chunks.

And all bar/gear/etc recipes along with it.

falseresync commented 5 years ago

You can do that with datapacks. In fact, that is what mods do

RViper80 commented 5 years ago

That's what I figured, but have no clue how to do that. Vivatech is the the only mod I have right now that seems to be adding ores, so looked in the code there and saw a oregen file in the resources part.

I copied that to my datapacks folder (data/\<uniquelowercaseid>/oregen/config.json) and added all named ores to the "ores": [] list, but all that did is made copper generate higher replacing grass, still no other ores.

Guess I'll try copying the whole "ores" section out of the older cotton resources 1.14.3 config and see if that does anything.

Stumbling around in the dark here and probably doing it all wrong :P

Edit: Well first error, just saw it fly by, it's ignoring my datapack because of capital letters in the namespace. Fixing that and restoring it to the list of ores like in Vivatech worked.

Some ores like Cobalt, Tungsten (important for Vivatech), Uranium, Palladium and a few others are registered, but are not actually generating anywhere. Those are Nether and End ores apparently.

I'm still not sure how to set up the generator settings though. Getting oddities like copper generating in the End in stone instead of endstone, and it replacing things like grass and sand in the overworld.

falseresync commented 5 years ago

You are able to generate all ores, right?

Copper in the grass and stone ores in Nether and in the End are bugs. We know about them

RViper80 commented 5 years ago

Ah, ok... Yes, all the ores generated correctly, except for those couple you mentioned as known, once I figured out how the datapacks worked.

ExoFrece commented 5 years ago

@RViper80 what did you do to generate the ores? with datapack? or config? can i have this?

falseresync commented 5 years ago

Create file like this: https://github.com/CottonMC/Vivatech/blob/master/src/main/resources/data/vivatech/oregen/config.json in your datapack

ExoFrece commented 5 years ago

i think im dumm i made a config.json file and put it in the datapack folder but ores not generate. what i make wrong? D:

the file looks so { "ores": [ "cobalt", "copper", "steel", "tungsten", "osmium", "aluminium", "amethyst", "iridium", "silver", "palladium", "peridot", "platinum", "ruby", "sapphire", "tin", "titanium", "topaz", "uranium", "zinc" ] }

is this wrong or put i in the wrong folder?

RViper80 commented 5 years ago

That's good, that's exactly what I have in mine. The folder structure has to be specific though, .minecraft/datapacks/\<whatever folder you want>/data/\<unique folder name>/oregen/

The \<unique folder name> can be anything, the only restrictions I found is it has to be all lowercase, another datapack can't already have that folder name, and I didn't put any spaces in it.

The only other thing you may need is a pack.mcmeta file in the same spot as the 'data' folder is. I just copied the one from the cotton_generated folder.

Example paths for you could be
.minecraft/datapacks/ExoFreceGen/data/pack.mcmeta .minecraft/datapacks/ExoFreceGen/data/cottongenall/oregen/config.json

The 'ExoFreceGen' and 'cottongenall' parts can be whatever you want as long as they aren't used already in the datapacks folder.

Edited to clarify both file requirements a bit.

ExoFrece commented 5 years ago

that is exactly what i have done but still no ores :(

RViper80 commented 5 years ago

Hmm... not sure what to say then. As long as that 2nd unique named folder is lowercase it should work. When generating a new world you should have something like this in the logs as well, right before the 'preparing spawn area' messages. (with only Cotton, CR, and Fabric API loaded)

[18:15:11] [Server thread/INFO]: Reloading ResourceManager: Default, Cotton Resources, fabric-mining-levels-v0, \<Your Datapack first folder name>, cotton_generated [18:15:12] [Server thread/INFO]: [COTTON RESOURCES]: Final set of generator keys available: [titanium, osmium, cobalt, amethyst, aluminum, lead, ruby, iridium, platinum, tungsten, peridot, topaz, tin, palladium, copper, silver, uranium, zinc, sapphire] [18:15:12] [Server thread/INFO]: [COTTON RESOURCES]: Enabled generators: [osmium, cobalt, aluminum, amethyst, lead, ruby, iridium, platinum, tungsten, peridot, tin, topaz, copper, palladium, silver, uranium, zinc, sapphire]

ExoFrece commented 5 years ago

[01:16:17] [Server thread/INFO]: [COTTON RESOURCES]: Final set of generator keys available: [titanium, osmium, cobalt, amethyst, aluminum, lead, ruby, iridium, platinum, tungsten, peridot, topaz, tin, palladium, copper, silver, uranium, zinc, sapphire] [01:16:17] [Server thread/INFO]: [COTTON RESOURCES]: Enabled generators: []

By Enabled, the line is empty. It does not matter how many mods I have, but I have also tested only with cotton, cr and fabric API nevertheless the same problem.

Edit: i see my datapack is not found [01:36:21] [Server thread/INFO]: Reloading ResourceManager: Default, Cotton Resources, fabric-mining-levels-v0, cotton_generated my first foldername ist cottonoregen but is not visible :(

RViper80 commented 5 years ago

Here's my folder, maybe you can see what you're missing.

Datapack

Also here's my config.json (had to rename the extension to upload)... maybe you have something being added to it that we don't see (text formatting from some editors) config.txt

.

ExoFrece commented 5 years ago

Finaly !!! thanks you are my hero :D is a bit embarrassing now... i miss the pack.mcmeta