CottonMC / CottonResources

Reference mod for ores, ingots, tools, liquids, and all you can imagine.
MIT License
17 stars 12 forks source link

Coal coke does not power minecarts #39

Closed muzikbike closed 4 years ago

muzikbike commented 5 years ago

From what I remember, those old tech mods that added coal coke had it power minecart trains just as coal and charcoal do. This is not the case with cotton resources's coal coke. While clicking on a minecart with it does cause it to move, this happens with pretty much every other item and the lack of smoke particles emanating from the furnace shows it's not actually powered. 2019-09-13_19 18 15 2019-09-13_19 18 43 2019-09-13_19 18 56

LemmaEOF commented 5 years ago

Huh, I'd expect the minecart furnace to use the fuel tick registry. I'm pretty sure Falk expected that too, so we didn't think to mix into the furnace cart to make it support other stuff.

falkreon commented 4 years ago

yeah, I'm surprised that it doesn't ask abstract furnace whether the item is fuel

Frontrider commented 4 years ago

It's hard-coded for coal and charcoal, with a fixed fuel value. Changing that is out of scope for this mod in my opinion.

B0oundary has an idea, but that won't be in this mod.

Linguardium commented 4 years ago

seems this ought to be closed. also in case someone stumbles on this, i added this to the item compatibility mod i made: https://github.com/Linguardium/ItemCompat

LemmaEOF commented 4 years ago

Item Compat should definitely help with this. Since we don't really wanna do those mixins ourselves, I'm gonna close this for now.