Incompatible with LibCD (outdated Jankson)

CottonMC / CottonResources

Reference mod for ores, ingots, tools, liquids, and all you can imagine.

MIT License

17 stars 12 forks source link

Closed Linguardium closed 4 years ago

Linguardium commented 4 years ago

Describe the bug Crash on launch with LibCD (or a mod that requires and includes it)

To Reproduce Steps to reproduce the behavior: install Fabric API, LibCD (2.2.2 - 2.3.0 tested), and the 1.15.2 release of cotton resources launch

Expected behavior Optional A clear and concise description of what you expected to happen.

Screenshots Optional If applicable, add screenshots to help explain your problem.

Version of the (please complete the following information):

LemmaEOF commented 4 years ago

can you provide some logs?

Linguardium commented 4 years ago

LemmaEOF commented 4 years ago

Ah, looks like C-R's Jankson version is out of date. I can fix that quickly tomorrow.

EndangeredNayla commented 4 years ago

This is the one reason fabric is bad, Embedded Jars that have incompatibilities inside the embeded mod

LemmaEOF commented 4 years ago

Honestly forge isn’t too much better with dependency management. This one’s on me because I did the PR review and didn’t catch it.

i509VCB commented 4 years ago

Will be fixed in the next update coming tonight. Will merge when I get home in about 2 hours.

i509VCB commented 4 years ago

This should be fixed in 1.5.1 (released today), please respond if things are still broken