CottonMC / CottonResources

Reference mod for ores, ingots, tools, liquids, and all you can imagine.
MIT License
17 stars 12 forks source link

Gems use c:names tag instead of c:name_gems #57

Open lukebemish opened 4 years ago

lukebemish commented 4 years ago

Is your feature request related to a problem? Please describe. As the title says. This breaks compatibility with mods that use the c:name_gems format, such as Tech Reborn.

Describe the solution you'd like I'm not sure if other mods are currently using the c:name format, but I think a good solution here would be to either use both tags, switch to the c:name_gems format, or nest one inside the other

Describe alternatives you've considered As mentioned in TechReborn/TechReborn#2106, it looks like the best bet here is probably to change this on the Cotton Resources side, to stick with a relatively commonly used convention. That said, I am not sure if the c:name format is used often, so this is by no means necessarily a perfect measure. To keep compatibility, the items could be added to both tags.