search

CottonMC / Epicurean

The food revolution for Fabric 1.15
MIT License
6 stars 5 forks source link

The crop block from epicurean should call super for appendProperties implementation #30

Closed liach closed 4 years ago

liach commented 4 years ago

Describe the bug The crop block from epicurean should call super for appendProperties implementation.

https://github.com/CottonMC/Epicurean/blob/7785185002e3d87cb79bd9087131555151634eec/src/main/java/io/github/cottonmc/epicurean/block/crop/HarvestableCropBlock.java#L71

This apparently causes crashes with other mods that add properties to all crop blocks, such as demeter. demeters' addition See Wtoll/demeter#13

To Reproduce Steps to reproduce the behavior:

  1. Install both demeter and epicurean
  2. Plant epicurean block and crash

Expected behavior Optional The epicurean crop block should include properties from base crop block

Version of the (please complete the following information): See Wtoll/demeter#13

LemmaEOF commented 4 years ago

ah yeah, I didn't think of this when I wrote this code. I'll fix this when I have time.

liach commented 4 years ago

Fyi this one needs updating as well https://github.com/CottonMC/Epicurean/blob/26a1eb9f0430da9632c18c374e63c7e02a8a8fce/src/main/java/io/github/cottonmc/epicurean/block/crop/PickableCropBlock.java#L18-L21

LemmaEOF commented 4 years ago

I don't know if I can call to super on PickableCropBlock#appendProperties, sadly, as that would then force it to add Properties.AGE_7 as well, which I do not want. I'll try it, but if it breaks things I'm reverting.