Cotya / magento-composer-installer

Composer installer for Magento modules
212 stars 77 forks source link

Composer does not install the magento core package #10

Closed timmtim closed 9 years ago

timmtim commented 9 years ago

In my composer.json file i have listed the magento/core package as a dependency for my project. I use version 2.1.1 of the magento-composer-installer. Last week i tried to do a clean deploy of the project using composer. The magento 1.9 package is downloaded to the vendor folder, but is not "deployed" into the magento web folder. I know for sure that this has worked in the past. What is de correct procedure on this?

Flyingmana commented 9 years ago

could you post a minimal composer.json to reproduce this problem, so I can try to debug it?

ottosmittenaar commented 9 years ago

Hi,

I have exactly the same problem.

{
    "name": "dewitschijndel/project",
    "type": "project",
    "repositories" : [
        {
            "type": "composer",
            "url": "http://packages.firegento.com"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento/language-nl_nl.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento/module-seo.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento/theme-admin.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento/patches.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento-modules/multisafepay-msp.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento-modules/amasty-shiprules.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento-modules/fooman-surcharge.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento-modules/mgt-akismet.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento-modules/tm-firecheckout.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento-modules/tbt-betterstoresearch.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:shopbase-magento-modules/mana-layered-navigation-plus.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:dewitschijndel/theme-package-rdws.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:dewitschijndel/theme-package-brands.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:dewitschijndel/module-question.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:dewitschijndel/module-tellafriend.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:dewitschijndel/module-base.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:dewitschijndel/module-linq5.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:dewitschijndel/module-feed.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:headlineinteractive/module-menu-with-brands.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:headlineinteractive/module-brands.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:headlineinteractive/module-simpleprices.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:headlineinteractive/module-ajax-cart.git"
        },
        {
            "type" : "vcs",
            "url" : "git@bitbucket.org:djbokkeman/module-default-shipping.git"
        }
    ],
    "require" : {
        "magento/core" : "1.9.1.0",
        "shopbase-magento-modules/amasty_shiprules" : "dev-master",
        "shopbase-magento-modules/fooman_surcharge" : "dev-master",
        "shopbase-magento-modules/mgt_akismet" : "dev-master",
        "shopbase-magento-modules/multisafepay_msp" : "dev-master",
        "shopbase-magento-modules/mana_layered-navigation-plus" : "dev-master",
        "headlineinteractive/module-default-shipping" : "dev-master",
        "headlineinteractive/module-menu-with-brands" : "dev-master",
        "headlineinteractive/module-brands" : "dev-master",
        "headlineinteractive/module-ajax-cart" : "dev-master",
        "headlineinteractive/module-simpleprices" : "dev-master",
        "dewitschijndel/module-question" : "dev-master",
        "dewitschijndel/module-tellafriend" : "dev-master",
        "dewitschijndel/module-linq5" : "dev-master",
        "dewitschijndel/theme-package-brands" : "dev-master",
        "dewitschijndel/theme-package-rdws" : "dev-master",
        "ebizmarts/magemonkey" : "1.1.32",
        "connect20/adwise_dynamicremarketing" : "1.0.2",
        "connect20/aschroder_smtppro" : "2.0.5",
        "connect20/morningtime_buckaroo" : "1.3.2.4",
        "shopbase-magento/language-nl_nl" : "dev-master",
        "shopbase-magento/module-seo" : "dev-master",
        "shopbase-magento/theme-admin" : "dev-master",
        "dewitschijndel/module-base" : "dev-master",
        "shopbase-magento/patches": "dev-master"
    },
    "extra" : {
        "magento-root-dir" : "public/",
        "magento-deploystrategy": "copy",
        "magento-force": true,
        "magento-deploy-ignore": {
            "connect20/aschroder_smtppro": [
                "/composer.json",
                "/modman",
                "/README.md"
            ],
            "aschroder/smtp_pro": [
                "/composer.json",
                "/modman",
                "/README.md"
            ],
            "ebizmarts/magemonkey": [
                "/app/etc/modules/Ebizmarts_AbandonedCart.xml",
                "/app/etc/modules/Ebizmarts_Autoresponder.xml",
                "/app/etc/modules/Ebizmarts_Mandrill.xml",
                "/app/etc/modules/Ebizmarts_SweetMonkey.xml"
            ],
            "shopbase-magento-modules/fooman_surcharge": [
                "/app/etc/modules/Fooman_Common.xml"
            ],
            "shopbase-magento-modules/mana_layered-navigation-plus": [
                "/app/etc/modules/Mana_Seo.xml",
                "/app/etc/modules/ManaPro_FilterClear.xml",
                "/app/etc/modules/ManaPro_FilterColors.xml",
                "/app/etc/modules/ManaPro_FilterDropdown.xml",
                "/app/etc/modules/ManaPro_FilterGroup.xml",
                "/app/etc/modules/ManaPro_FilterHelp.xml",
                "/app/etc/modules/ManaPro_FilterPositioning.xml",
                "/app/etc/modules/ManaPro_FilterRadios.xml",
                "/app/etc/modules/ManaPro_FilterSeoLinks.xml",
                "/app/etc/modules/ManaPro_FilterShowMore.xml",
                "/app/etc/modules/ManaPro_FilterSlider.xml",
                "/app/etc/modules/ManaPro_FilterSuperSlider.xml",
                "/app/etc/modules/ManaPro_FilterTree.xml"
            ],
            "magento/core": [
                "/app/etc/modules/Mage_Api2.xml",
                "/app/etc/modules/Mage_Authorizenet.xml",
                "/app/etc/modules/Mage_Connect.xml",
                "/app/etc/modules/Mage_Downloadable.xml",
                "/app/etc/modules/Mage_Oauth.xml",
                "/app/etc/modules/Mage_PageCache.xml",
                "/app/etc/modules/Mage_Widget.xml",
                "/app/etc/modules/Phoenix_Moneybookers.xml"
            ]
        }
    }
}

Hope you can help. I tried everything.

Best regards, Otto Smittenaar

Flyingmana commented 9 years ago

looks like you did not specify a version of the installer, try to require version 2.* of the installer and try again.

ottosmittenaar commented 9 years ago

Hi Daniel,

Thanks for the quick reply. I normally use:

"magento-hackathon/magento-composer-installer" : "~2.1"

I wanted to try the latest version, than it is not working. I have a lot of issue to fully assemble everything te right way. Thats why I wanted to test the latest version.

Best regards, Otto Smittenaar

Flyingmana commented 9 years ago

the last version (3.0.x) does not support the core package.

It may get added again, if someone contributes it in a way so it works with the other features, or if someone is willing to provide some budget. Or people start to use a dedicated installer just for the core, like for example https://github.com/AydinHassan/magento-core-composer-installer

ottosmittenaar commented 9 years ago

Okey, clear.

I'm getting used to composer as a user. I do not yet understand the programming side of composer, yet. I will have a look at the https://github.com/AydinHassan/magento-core-composer-installer.

Thanks again for the quick feedback.

floodedcodeboy commented 9 years ago

@Flyingmana ... is it possible to use both this and AydinHassan/magento-core-composer-installer packages together?

AydinHassan commented 9 years ago

@floodedcodeboy yes it is :)

Flyingmana commented 9 years ago

I assume this Issue is solved? or anyone can still reproduce there is a problem for 2.x?

razbakov commented 9 years ago

@Flyingmana why don't we add magento-core installer?

Flyingmana commented 9 years ago

@razbakov which one? With which features?

razbakov commented 9 years ago

I added magento 1.9.2.0 to firegento/magento repo and I wanted to test it,

but 1) it doesn’t work with extra.map in composer.json 2) I don’t think cp -R magento magento is a good solution here 3) I used modman file in kirchbergerknorr/magento and it worked well, but I also don’t like this approach as well

any other idea how should we do that?

Flyingmana commented 9 years ago

They decided for type "magento-core" which is not supported by our plugin. I recommend to use the plugin mentioned in our readme.

You could also overwrite the package definition with another type but same source paths, then extra.map should work, too.