search

Cotya / magento-composer-installer

Composer installer for Magento modules
212 stars 77 forks source link

Stop following symlinks on deploy #101

Closed barryvdh closed 8 years ago

barryvdh commented 8 years ago

This should fix #70

When local repo is used, this links the magento folders to vendor, instead of the local repo. This makes sure that, when a package is installed, the symlink isn't working anymore.

Does need review if it actually solves all problems with local repos.

(Not sure if it should actually remove all dead symlinks, or that this isn't needed now)

AydinHassan commented 8 years ago

I think this needs a test case, it will help explain why the code is there and prevent regressions.

barryvdh commented 8 years ago

I'm not sure if this is still actually needed, but imho it does make sense to symlink to the vendor dir, so not left-over symlinks can remain on the system. But I'll see if I can reproduce it and create a test case.

Flyingmana commented 8 years ago

as the related issue got fixed, I close this PR.