Cotya / magento-composer-installer

Composer installer for Magento modules
212 stars 77 forks source link

Problem with 'magento-deploy-ignore' #13

Open ottosmittenaar opened 9 years ago

ottosmittenaar commented 9 years ago

Hi,

When I use the following ignore list, more than only the ignored files are ignored. For example 'app/code/core' is not copied and other files and directories as well.

"magento-deploy-ignore": {
    "connect20/aschroder_smtppro": ["/composer.json"],
    "connect20/aschroder_smtppro": ["/modman"],
    "connect20/aschroder_smtppro": ["/README.md"],
    "aschroder/smtp_pro": ["/composer.json"],
    "aschroder/smtp_pro": ["/modman"],
    "aschroder/smtp_pro": ["/README.md"],
    "ebizmarts/magemonkey": ["/app/etc/modules/Ebizmarts_AbandonedCart.xml"],
    "ebizmarts/magemonkey": ["/app/etc/modules/Ebizmarts_Autoresponder.xml"],
    "ebizmarts/magemonkey": ["/app/etc/modules/Ebizmarts_Mandrill.xml"],
    "ebizmarts/magemonkey": ["/app/etc/modules/Ebizmarts_SweetMonkey.xml"],
    "shopbase-magento-modules/fooman_surcharge": ["/app/etc/modules/Fooman_Common.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/Mana_Seo.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterClear.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterColors.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterDropdown.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterGroup.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterHelp.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterPositioning.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterRadios.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterSeoLinks.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterShowMore.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterSlider.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterSuperSlider.xml"],
    "shopbase-magento-modules/mana_layered-navigation-plus": ["/app/etc/modules/ManaPro_FilterTree.xml"],
    "magento/core": ["/app/etc/modules/Mage_Api2.xml"],
    "magento/core": ["/app/etc/modules/Mage_Authorizenet.xml"],
    "magento/core": ["/app/etc/modules/Mage_Connect.xml"],
    "magento/core": ["/app/etc/modules/Mage_Downloadable.xml"],
    "magento/core": ["/app/etc/modules/Mage_Oauth.xml"],
    "magento/core": ["/app/etc/modules/Mage_PageCache.xml"],
    "magento/core": ["/app/etc/modules/Mage_Widget.xml"],
    "magento/core": ["/app/etc/modules/Phoenix_Moneybookers.xml"]
}

the following gives the same result:

"magento-deploy-ignore": {
    "connect20/aschroder_smtppro": [
        "/composer.json",
        "/modman",
        "/README.md"
    ],
    "aschroder/smtp_pro": [
        "/composer.json",
        "/modman",
        "/README.md"
    ],
    "ebizmarts/magemonkey": [
        "/app/etc/modules/Ebizmarts_AbandonedCart.xml",
        "/app/etc/modules/Ebizmarts_Autoresponder.xml",
        "/app/etc/modules/Ebizmarts_Mandrill.xml",
        "/app/etc/modules/Ebizmarts_SweetMonkey.xml"
    ],
    "shopbase-magento-modules/fooman_surcharge": [
        "/app/etc/modules/Fooman_Common.xml"
    ],
    "shopbase-magento-modules/mana_layered-navigation-plus": [
        "/app/etc/modules/Mana_Seo.xml",
        "/app/etc/modules/ManaPro_FilterClear.xml",
        "/app/etc/modules/ManaPro_FilterColors.xml",
        "/app/etc/modules/ManaPro_FilterDropdown.xml",
        "/app/etc/modules/ManaPro_FilterGroup.xml",
        "/app/etc/modules/ManaPro_FilterHelp.xml",
        "/app/etc/modules/ManaPro_FilterPositioning.xml",
        "/app/etc/modules/ManaPro_FilterRadios.xml",
        "/app/etc/modules/ManaPro_FilterSeoLinks.xml",
        "/app/etc/modules/ManaPro_FilterShowMore.xml",
        "/app/etc/modules/ManaPro_FilterSlider.xml",
        "/app/etc/modules/ManaPro_FilterSuperSlider.xml",
        "/app/etc/modules/ManaPro_FilterTree.xml"
    ],
    "magento/core": [
        "/app/etc/modules/Mage_Api2.xml",
        "/app/etc/modules/Mage_Authorizenet.xml",
        "/app/etc/modules/Mage_Connect.xml",
        "/app/etc/modules/Mage_Downloadable.xml",
        "/app/etc/modules/Mage_Oauth.xml",
        "/app/etc/modules/Mage_PageCache.xml",
        "/app/etc/modules/Mage_Widget.xml",
        "/app/etc/modules/Phoenix_Moneybookers.xml"
    ]
}

Hope you can help with this.

Best regards, Otto Smittenaar

ottosmittenaar commented 9 years ago

Update:

It looks like that the problem is caused by only the "magento/core" entries. I have removed only these and than it is working correctly.

proxium commented 9 years ago

Hello, I have the following with: "magento-hackathon/magento-composer-installer": "3.0.5"

"extra": {
        "magento-root-dir": "src/",
        "auto-append-gitignore": true,
        "magento-deploystrategy": "copy",
        "magento-force": true,
        "magento-deploy-ignore": {
            "kirchbergerknorr/magento": ["/skin/frontend/base/default/favicon.ico"],
            "kirchbergerknorr/magento": ["/downloader/"]
        },
        "magento-deploy-sort-priority": {
            "kirchbergerknorr/magento": "100"
        },
        "composer-command-registry": [
            "MagentoHackathon\\Composer\\Magento\\Command\\DeployCommand"
        ]
    }

When I execute the command: composer.phar run-script post-install-cmd -vvv -- --redeploy

/downloader/ and favicon.ico still copied

Using this syntax didn't help too

        "magento-deploy-ignore": {
            "*": ["/skin/frontend/base/default/favicon.ico"],
            "*": ["/downloader/"]
        },
AydinHassan commented 9 years ago

@proxium Can you create a new issue please. I'll take a look at some point, in the mean time could you try without the leading slash?

proxium commented 9 years ago

New issue https://github.com/Cotya/magento-composer-installer/issues/67