search

Cotya / magento-composer-installer

Composer installer for Magento modules
211 stars 77 forks source link

Replace windows path to unix path #46

Closed AydinHassan closed 9 years ago

AydinHassan commented 9 years ago

Should fix #45, not tested as I don't have a windows box

AydinHassan commented 9 years ago

@tkn98 I just saw this as the easier fix, sure we could escape the json properly, but does it really matter?

tkn98 commented 9 years ago

@AydinHassan: Absolutely: You should never fix bugs on best guess and good luck, but by fixing the underlying issue, the actual flaw. At least I strongly suggest that. Otherwise you have not used the error properly and make it even harder to find it (cover it up instead of fixing it).

tkn98 commented 9 years ago

@AydinHassan: But please the issue as well, I was not able to reproduce it today and it might be related to an older version.

AydinHassan commented 9 years ago

@tkn98 You are right, I was being lazy. Doesn't look like any code has been changed relating to the composer.json updating recently. Maybe something has changed in the actual Composer components which seem to be in use.