search

Cotya / magento-composer-installer

Composer installer for Magento modules
211 stars 77 forks source link

Modify GitIgnore processing to retain layout #84

Closed buffcode closed 8 years ago

buffcode commented 8 years ago

This modified GitIgnore processing has a different way of processing the single lines and avoids changing the layout, removing duplicate comments, whitelines etc. (issues of the current master).

Includes two new tests to assert this behaviour.

Fixes #83 as well.

AydinHassan commented 8 years ago

Looks good :+1: Could you squash the commits and add an entry to the change log please?

buffcode commented 8 years ago

Commits squashed and change log updated

aadmathijssen commented 8 years ago

Hi,

Is there any chance this pull requests is merged soon?

I encounter this issue almost every day.

Thanks.

Flyingmana commented 8 years ago

Iam sorry for the long time the merge needed, I will do the comming release start of next week

aadmathijssen commented 8 years ago

No problem, thanks for merging!