search

Cotya / magento-composer-installer

Composer installer for Magento modules
211 stars 77 forks source link

Resolve package.xml mappings edge case #91

Closed mikeymike closed 8 years ago

mikeymike commented 8 years ago

Sometimes dirs are mapped into empty dir tags causing double slashes in the mapping.

AydinHassan commented 8 years ago

👍 We noticed this with a Fishpig extension from connect.

The windows build seems to have 404'd when installing OpenSSL. @Flyingmana could you try restart the build to see if it was a one off?

Flyingmana commented 8 years ago

yeah, openssl got updated again... they always remove the old downloads. Will see what I can do about it.

Patch looks good besides that, will get merged after I fixied the windows CI

AydinHassan commented 8 years ago

Awesome, thanks 😀

Sent from my iPhone

On 30 Jan 2016, at 11:02, Daniel Fahlke notifications@github.com wrote:

yeah, openssl got updated again... they always remove the old downloads. Will see what I can do about it.

Patch looks good besides that, will get merged after I fixied the windows CI

— Reply to this email directly or view it on GitHub.

adragus-inviqa commented 8 years ago

@mikeymike - Could you please add a changelog entry, too?

mikeymike commented 8 years ago

@adragus-inviqa I can do, but after reading the contributing.md this seemed too small of a change to warrant an entry in the changelog. @Flyingmana what do you think?

Flyingmana commented 8 years ago

an additional entry is always good for PRs, and it could affect something. So feel free to add one.

Besides that, I will merge this PR on the weekend, even if the windows CI has not recovered

Flyingmana commented 8 years ago

windows CI is green, will merge after work :)