search

Couchers-org / couchers

The next-generation couch surfing platform. Free forever. Community‑led. Non‑profit. Modern. Chuck us a star :)
https://couchers.org
MIT License
359 stars 76 forks source link

Enter confirmation of add link modal confirms profile page editing #4115

Open almereyda opened 2 years ago

almereyda commented 2 years ago

When wanting to add a link, I have to select text, click on a button, click in the other input field, where no URL has been guessed from the selection, and can add a URL. Confirming this modal with pressing Return will save the user profile form, instead.

darrenvong commented 1 year ago

I'm not sure I fully understand what the requested improvement here is. Is this referring to confirmation dialog to warn the user to not leave the profile edit page until they pressed the "save" button?

almereyda commented 1 year ago

Yes, it seems adding a link to a rich-text description field in the user profile opens up a popup, where the URL of a link can be entered.

Confirming this modal by pressing Return will not close it, but the Return will be interpreted by the underlying page, and the link will be lost.

darrenvong commented 1 year ago

Right, I got ya and can reproduce this too.

This will require some digging since that rich text field is some third party editor we're using. The focus trapping is clearly a bit off!

I'll transfer this to our new frontend specific repo so this is not lost in the legacy monorepo