Couchers-org / couchers

The next-generation couch surfing platform. Free forever. Community‑led. Non‑profit. Modern. Chuck us a star :)
https://couchers.org
MIT License
389 stars 79 forks source link

New Events Page - DESIGN ONLY #4863

Closed nabramow closed 1 month ago

nabramow commented 1 month ago

This is the DESIGN ONLY for the EventsList and the EventItem card. This will merge into the "web/feature/new-events-page" feature branch, not prod, so no need to worry. I am breaking them up as it will be a big feature and it's easier to review in pieces.

Please only review the design, the loading and functionality will come in the next PR.

Right now I'm just using mock data from app/web/test/fixtures/events.json. If you want to test different UI like a very long title, online event, etc. you can add or adjust the data there.

Design mocks in these tickets: #4823, #4784

Web frontend checklist

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
couchers ✅ Ready (Inspect) Visit Preview Sep 23, 2024 6:27am
bakeiro commented 1 month ago

overall good, didn't spot nothing improveable in the code, tomorrow I will finish the review ;)

bakeiro commented 1 month ago

petition about the tabs, can we use the original tabs? to maintain consistency (as the picture attached) image

I think was a misunderstading with the mockups, my mockups are just to understand the abstract idea what I wanted to achieve, but we should keep using the original UI style/guidelines as we have in other pages, see comments in the attached pictures (maybe it's my fault because wasn't totally clear, but yeah for these mockups I'm using an AI to generate them, that's why they don't follow the Couchers UI guidelines 😅) image image

bakeiro commented 1 month ago

new issue created https://github.com/Couchers-org/couchers/issues/4877 PR approved