Implement Recursive Pagination for getEvents - Githubissues

CougarCS / CougarCS-Backend

An Express API to service the CougarCS website.

5 stars 27 forks source link

Implement Recursive Pagination for getEvents #297

Closed rossvc closed 1 year ago

rossvc commented 1 year ago

maxResults can be changed to further optimize efficiency & reduce spamming

What type of PR is this? (check all applicable)

[ ] ♻️ Refactor
[ ] ✨ Feature
[X] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 📝 Documentation Update
[ ] 🔖 Release
[ ] 🚩 Other

Description

Switched to recursive implementation of getEvents, maxResults in URL can be adjusted to further improve efficiency and reduce api spam.

Related Tickets & Documents

Refers to #296

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 readme
[ ] 📜 contributing.md
[ ] 📓 docs
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: b42cf6e79bac302ffeb12e76a53ad1f6bd044da2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR