search

CouncilDataProject / cdp-backend

Data storage utilities and processing pipelines used by CDP instances.
https://councildataproject.org/cdp-backend
Mozilla Public License 2.0
22 stars 26 forks source link

bug/catch-timeout-in-event-gather #157

Closed isaacna closed 2 years ago

isaacna commented 2 years ago

Link to Relevant Issue

This pull request resolves #154

Description of Changes

The error here was caused by a requests.ConnectionError.

I added a catch for ConnectionError for every try statement that uploads a db model and has resource_exists validation.

I'm assuming that wherever we don't have a try statement, we wouldn't want to proceed in the pipeline if something errors out during that upload_db_model step. But let me know if this assumption isn't correct

codecov[bot] commented 2 years ago

Codecov Report

Merging #157 (ee791de) into main (4f8b6c7) will increase coverage by 0.00%. The diff coverage is 45.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files          50       50           
  Lines        2543     2544    +1     
=======================================
+ Hits         2404     2405    +1     
  Misses        139      139
Impacted Files Coverage Δ
cdp_backend/pipeline/event_gather_pipeline.py 85.71% <45.45%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f8b6c7...ee791de. Read the comment docs.