CouncilDataProject / cdp-backend

Data storage utilities and processing pipelines used by CDP instances.
https://councildataproject.org/cdp-backend
Mozilla Public License 2.0
22 stars 26 forks source link

feature/support-processing-m3u8-video-playlist-uris #188

Closed evamaxfield closed 2 years ago

evamaxfield commented 2 years ago

Link to Relevant Issue

https://github.com/CouncilDataProject/cdp-scrapers/pull/96#issuecomment-1114325009

Description of Changes

Include a description of the proposed changes.

Allows processing of m3u8 URIs.

What will happen is during resource_copy we will download and convert the m3u8 playlist to an mp4. Then during determining the video host, we check the original session video uri and see if it ends with ".m3u8" and if so, we host the already converted and saved locally m3u8 file.

codecov[bot] commented 2 years ago

Codecov Report

Merging #188 (c85dd3f) into main (5888bca) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   94.55%   94.60%   +0.04%     
==========================================
  Files          50       50              
  Lines        2607     2630      +23     
==========================================
+ Hits         2465     2488      +23     
  Misses        142      142              
Impacted Files Coverage Δ
cdp_backend/pipeline/event_gather_pipeline.py 86.00% <100.00%> (+0.28%) :arrow_up:
cdp_backend/tests/conftest.py 100.00% <100.00%> (ø)
...ckend/tests/pipeline/test_event_gather_pipeline.py 100.00% <100.00%> (ø)
cdp_backend/tests/utils/test_file_utils.py 100.00% <100.00%> (ø)
cdp_backend/utils/file_utils.py 92.99% <100.00%> (+0.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5888bca...c85dd3f. Read the comment docs.

evamaxfield commented 2 years ago

I have two actions running on my dev infrastructure to test:

  1. testing the manual / custom process event: https://github.com/JacksonMaxfield/cdp-dev/runs/6545676305?check_suite_focus=true
  2. testing the normal event gather: https://github.com/JacksonMaxfield/cdp-dev/runs/6545697019?check_suite_focus=true

if both succeed I will link to their page on my dev infra website and then likely merge after approvals! 🎉

evamaxfield commented 2 years ago

Both the normal event gather and the manual process special event succeeded

https://jacksonmaxfield.github.io/cdp-dev/#/events/0913ecd21d43 https://jacksonmaxfield.github.io/cdp-dev/#/events/99f4c2a99447

@tohuynh you happy with this PR if so I think I can merge. 🎉

tohuynh commented 2 years ago

Both the normal event gather and the manual process special event succeeded

https://jacksonmaxfield.github.io/cdp-dev/#/events/0913ecd21d43 https://jacksonmaxfield.github.io/cdp-dev/#/events/99f4c2a99447

@tohuynh you happy with this PR if so I think I can merge. 🎉

yes