CouncilDataProject / cdp-backend

Data storage utilities and processing pipelines used by CDP instances.
https://councildataproject.org/cdp-backend
Mozilla Public License 2.0
22 stars 26 forks source link

bugfix/infra-stack #202

Closed evamaxfield closed 2 years ago

evamaxfield commented 2 years ago

Almost complete fix for infra stack failing to deploy.

The current issue as a reminder is that Pulumi is losing track of the index creation job IDs.

After a bit of time debugging Pulumi, I figured I should try with just bare bones CLI tools and no fancy Pulumi or anything. Turns out it works better than before.

  1. Removes Pulumi entirely in favor of setting up infrastructure with gcloud, firebase cli, and gsutil. This means no Pulumi account will be required anymore.
  2. This adds the security rules creation directly to the process and CORS setup.
  3. Indexes and metadata doc are handling in Python with minimal scripts.
  4. It's way faster.

Left todo: determine the best method for mirror this in the cookiecutter and testing out a full deployment.

codecov[bot] commented 2 years ago

Codecov Report

Merging #202 (3e151fe) into main (2095b24) will decrease coverage by 2.50%. The diff coverage is 11.53%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   74.82%   72.32%   -2.51%     
==========================================
  Files          66       65       -1     
  Lines        3381     3404      +23     
==========================================
- Hits         2530     2462      -68     
- Misses        851      942      +91     
Impacted Files Coverage Δ
cdp_backend/bin/get_cdp_infrastructure_stack.py 0.00% <0.00%> (ø)
cdp_backend/bin/store_cdp_metadata_document.py 0.00% <0.00%> (ø)
cdp_backend/database/models.py 100.00% <ø> (ø)
cdp_backend/infrastructure/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
cdp_backend/database/types.py 100.00% <100.00%> (ø)
cdp_backend/tests/database/test_models.py 96.96% <100.00%> (-0.26%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.