CouncilDataProject / cdp-backend

Data storage utilities and processing pipelines used by CDP instances.
https://councildataproject.org/cdp-backend
Mozilla Public License 2.0
22 stars 26 forks source link

feature/basic-gcp-function-and-clipping-gcp-function #204

Closed evamaxfield closed 2 years ago

evamaxfield commented 2 years ago

~!!! No need to actually review this code, I just figured this would be a good place to ask questions !!!


This PR contains a very basic gcloud function that, when deployed, will respond to requests with a name parameter and say hello along with the shipped cdp-backend library version and the caller's IP.

CI has been updated to both lint, format, and type-check the function, and the infrastructure management has been updated to deploy the function and enable all the required services.

This won't get merged but it is easily enough of a proof of concept to show how we can easily do the video / audio clipping feature!

Which means that the tasks for the day of the hackathon are:

This was so easy to setup I am excited about other possibilities for functions to ship.

Only concern right now is that I am shipping this with "no auth" and I think that's fine, all of our stuff is no auth, but I want rate limiting potentially??

To make CI work I had to make a bunch of other small admin changes.

cc @Shak2000 (can't tag you as reviewer for some reason...)~

THIS IS THE CLIPPING FUNCTION ON THE BACKEND

codecov[bot] commented 2 years ago

Codecov Report

Merging #204 (698a195) into main (947a390) will decrease coverage by 0.05%. The diff coverage is 0.00%.

:exclamation: Current head 698a195 differs from pull request most recent head 9a60246. Consider uploading reports for the commit 9a60246 to get more accurate results

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   72.40%   72.35%   -0.06%     
==========================================
  Files          64       64              
  Lines        3428     3425       -3     
==========================================
- Hits         2482     2478       -4     
- Misses        946      947       +1     
Impacted Files Coverage Δ
cdp_backend/bin/get_cdp_infrastructure_stack.py 0.00% <0.00%> (ø)
cdp_backend/utils/file_utils.py 94.82% <0.00%> (+1.49%) :arrow_up:
cdp_backend/file_store/functions.py 88.09% <0.00%> (+7.24%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.