search

CouncilDataProject / cdp-backend

Data storage utilities and processing pipelines used by CDP instances.
https://councildataproject.org/cdp-backend
Mozilla Public License 2.0
22 stars 26 forks source link

feature/support-undownloadable-vimeo-links #205

Closed sagarrat7 closed 2 years ago

sagarrat7 commented 2 years ago

Link to Relevant Issue

This pull request resolves #191

Description of Changes

Use Vimeo.from_video_id() instead of Vimeo() when downloading from Vimeo. This supports downloading from URLs with the form: https://vimeo.com/showcase/6277394/video/722690793, as well as the previously supported form: https://vimeo.com/686512896.

codecov[bot] commented 2 years ago

Codecov Report

Merging #205 (945b27c) into main (1e5b807) will increase coverage by 0.20%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   72.29%   72.50%   +0.20%     
==========================================
  Files          64       64              
  Lines        3404     3415      +11     
==========================================
+ Hits         2461     2476      +15     
+ Misses        943      939       -4
Impacted Files Coverage Δ
cdp_backend/tests/conftest.py 100.00% <100.00%> (ø)
cdp_backend/tests/utils/test_file_utils.py 100.00% <100.00%> (ø)
cdp_backend/utils/file_utils.py 94.82% <100.00%> (+2.51%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.