search

CouncilDataProject / cdp-backend

Data storage utilities and processing pipelines used by CDP instances.
https://councildataproject.org/cdp-backend
Mozilla Public License 2.0
22 stars 26 forks source link

Issue with deploy-infra action on 3.2.5 due to missing webvtt #217

Closed conantp closed 1 year ago

conantp commented 1 year ago

Describe the Bug

Similar to #215, after merging in the PRs for 3.2.5, I'm receiving an error on the deploy-infra action due to missing webvtt:

File "/opt/hostedtoolcache/Python/3.10.7/x64/bin/get_cdp_infrastructure_stack", line 5, in <module> [17](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:18) from cdp_backend.bin.get_cdp_infrastructure_stack import main [18](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:19) File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/cdp_backend/bin/get_cdp_infrastructure_stack.py", line 12, in <module> [19](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:20) from cdp_backend.database import DATABASE_MODELS [20](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:21) File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/cdp_backend/database/__init__.py", line 9, in <module> [21](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:22) from . import models [22](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:23) File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/cdp_backend/database/models.py", line 12, in <module> [23](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:24) from ..utils import file_utils [24](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:25) File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/site-packages/cdp_backend/utils/file_utils.py", line 17, in <module> [25](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:26) import webvtt [26](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:27) ModuleNotFoundError: No module named 'webvtt' [27](https://github.com/sunshine-request/cdp-asheville/actions/runs/3178365057/jobs/5179770803#step:9:28) Error: Process completed with exit code 1.

Expected Behavior

Successful execution of deploy-infra action.

Reproduction

I'm not sure if there's anything specific to my instance, but I think you could probably reproduce this behavior by setting up an instance at 3.2.4, applying the PRs generate for 3.2.5, and watching the "Action" results.

Environment

https://github.com/sunshine-request/cdp-asheville

evamaxfield commented 1 year ago

Yes. Sorry about that. This has been fixed in 3.2.6 and already released: https://github.com/CouncilDataProject/pittsburgh-pa/actions/runs/3183779475

I'm not sure if there's anything specific to my instance, but I think you could probably reproduce this behavior by setting up an instance at 3.2.4, applying the PRs generate for 3.2.5, and watching the "Action" results.

I generally try to release new versions to seattle-staging before the dependabot stuff gets out. I was out-of-town and doing most of this stuff on my phone haha. Dependabot is automated so if I don't try a release before it automatically goes out then we are just out-of-luck. I could (and should) be better about releasing a dev-version first though.

conantp commented 1 year ago

Thanks @evamaxfield - 3.2.6 fixes the issue for me!